Skip to content

Commit c2f6fa4

Browse files
authored
Use AC_DEFINE_UNQUOTED where variables are used (#14647)
According to Autoconf documentation AC_DEFINE_UNQUOTED should be used, where shell variables are used in the macro arguments. https://www.gnu.org/software/autoconf/manual/autoconf-2.72/autoconf.html#index-AC_005fDEFINE_005fUNQUOTED-2 This also adds simple help descriptions to these CPP macros.
1 parent fc36d0e commit c2f6fa4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ext/dba/config.m4

+4-2
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,8 @@ AC_DEFUN([PHP_DBA_DB_CHECK],[
354354
])
355355
fi
356356
if test -n "$THIS_LIBS"; then
357-
AC_DEFINE(DBA_DB$1, 1, [ ])
357+
AC_DEFINE_UNQUOTED([DBA_DB$1], [1],
358+
[Define to 1 if Berkeley DB is compatible with version $1.])
358359
if test -n "$THIS_INCLUDE"; then
359360
AC_DEFINE_UNQUOTED(DB$1_INCLUDE_FILE, "$THIS_INCLUDE", [ ])
360361
fi
@@ -553,7 +554,8 @@ if test "$PHP_DB1" != "no"; then
553554
DB * dbp = dbopen("", 0, 0, DB_HASH, 0);
554555
]])],[
555556
AC_DEFINE_UNQUOTED(DB1_INCLUDE_FILE, "$THIS_INCLUDE", [ ])
556-
AC_DEFINE(DBA_DB1, 1, [ ])
557+
AC_DEFINE([DBA_DB1], [1],
558+
[Define to 1 if Berkeley DB is compatible with version 1.])
557559
THIS_RESULT=yes
558560
],[
559561
THIS_RESULT=no

0 commit comments

Comments
 (0)