Skip to content

Commit e7af08d

Browse files
committed
Hide xfail/xleak test summary
We don't show succeeding tests in the summary, and for all intents and purposes, these tests have succeeded, in that they behave as expected. I've seen the output confuse people on multiple occasions, for example GH-17105. Closes GH-17109
1 parent cdfd960 commit e7af08d

File tree

1 file changed

+0
-25
lines changed

1 file changed

+0
-25
lines changed

run-tests.php

-25
Original file line numberDiff line numberDiff line change
@@ -3144,18 +3144,6 @@ function get_summary(bool $show_ext_summary): string
31443144
$failed_test_summary .= "=====================================================================\n";
31453145
}
31463146

3147-
if (count($PHP_FAILED_TESTS['XFAILED'])) {
3148-
$failed_test_summary .= '
3149-
=====================================================================
3150-
EXPECTED FAILED TEST SUMMARY
3151-
---------------------------------------------------------------------
3152-
';
3153-
foreach ($PHP_FAILED_TESTS['XFAILED'] as $failed_test_data) {
3154-
$failed_test_summary .= $failed_test_data['test_name'] . $failed_test_data['info'] . "\n";
3155-
}
3156-
$failed_test_summary .= "=====================================================================\n";
3157-
}
3158-
31593147
if (count($PHP_FAILED_TESTS['BORKED'])) {
31603148
$failed_test_summary .= '
31613149
=====================================================================
@@ -3206,19 +3194,6 @@ function get_summary(bool $show_ext_summary): string
32063194
$failed_test_summary .= "=====================================================================\n";
32073195
}
32083196

3209-
if (count($PHP_FAILED_TESTS['XLEAKED'])) {
3210-
$failed_test_summary .= '
3211-
=====================================================================
3212-
EXPECTED LEAK TEST SUMMARY
3213-
---------------------------------------------------------------------
3214-
';
3215-
foreach ($PHP_FAILED_TESTS['XLEAKED'] as $failed_test_data) {
3216-
$failed_test_summary .= $failed_test_data['test_name'] . $failed_test_data['info'] . "\n";
3217-
}
3218-
3219-
$failed_test_summary .= "=====================================================================\n";
3220-
}
3221-
32223197
if ($failed_test_summary && !getenv('NO_PHPTEST_SUMMARY')) {
32233198
$summary .= $failed_test_summary;
32243199
}

0 commit comments

Comments
 (0)