Merge pull request php-webdriver#249 from iFixit/remote-web-driver--make-new-element-protected

RemoteWebElement: allow overriding construction

Author: gfosco

lib/Remote/RemoteWebDriver.php

@@ -430,7 +430,7 @@ public function action() {
    * @param string $id The id of the element to be created.
    * @return RemoteWebElement
    */
-  private function newElement($id) {
+  protected function newElement($id) {
     return new RemoteWebElement($this->getExecuteMethod(), $id);
   }
 

lib/Remote/RemoteWebElement.php

@@ -416,8 +416,7 @@ public function equals(WebDriverElement $other) {
    *
    * @return RemoteWebElement
    */
-  private function newElement($id) {
-    $class = get_class($this);
-    return new $class($this->executor, $id);
+  protected function newElement($id) {
+    return new static($this->executor, $id);
   }
 }

lib/Support/Events/EventFiringWebDriver.php

@@ -85,7 +85,7 @@ public function getWebDriver() {
    * @param WebDriverElement $element
    * @return EventFiringWebElement
    */
-  private function newElement(WebDriverElement $element) {
+  protected function newElement(WebDriverElement $element) {
     return new EventFiringWebElement($element, $this->getDispatcher());
   }
 

lib/Support/Events/EventFiringWebElement.php

@@ -78,8 +78,8 @@ public function getElement() {
    * @param WebDriverElement $element
    * @return EventFiringWebElement
    */
-  private function newElement(WebDriverElement $element) {
-    return new EventFiringWebElement($element, $this->getDispatcher());
+  protected function newElement(WebDriverElement $element) {
+    return new static($element, $this->getDispatcher());
   }
 
   /**