Merge pull request code-dot-org#834 from code-dot-org/no-update-userscript

reduce writes for logged in users

Author: laurelfan

dashboard/app/models/user.rb

@@ -560,14 +560,14 @@ def track_script_progress(script)
 
       update = {}
       update[:started_at] = time_now unless user_script.started_at
-      update[:last_progress_at] = time_now 
+      update[:last_progress_at] = time_now unless user_script.last_progress_at
 
       if !user_script.completed_at && user_script.check_completed?
         update[:completed_at] = time_now
       end
 
       # update_all bypasses validations/transactions/etc
-      UserScript.where(id: user_script.id).update_all(update)
+      UserScript.where(id: user_script.id).update_all(update) unless update.empty?
     end
   end
 

dashboard/test/controllers/activities_controller_test.rb

@@ -333,7 +333,7 @@ def studio_program_with_text(text)
     assert_equal @script_level.script, user_script.script
     assert_equal @user, user_script.user
     assert_equal script_start_date.to_i, user_script.started_at.to_i
-    assert user_script.started_at != user_script.last_progress_at
+#    assert user_script.started_at != user_script.last_progress_at # I turned off updates 
     assert user_script.assigned_at.nil?
     assert user_script.completed_at.nil?
   end