File tree 2 files changed +18
-1
lines changed 2 files changed +18
-1
lines changed Original file line number Diff line number Diff line change @@ -86,7 +86,9 @@ def update_blocks
86
86
# PATCH/PUT /levels/1
87
87
# PATCH/PUT /levels/1.json
88
88
def update
89
- if level_params [ :name ] && @level . name . downcase == level_params [ :name ] . downcase
89
+ if level_params [ :name ] &&
90
+ @level . name != level_params [ :name ] &&
91
+ @level . name . downcase == level_params [ :name ] . downcase
90
92
# do not allow case-only changes in the level name because that confuses git on OSX
91
93
@level . errors . add ( :name , 'Cannot change only the capitalization of the level name (it confuses git on OSX)' )
92
94
render json : @level . errors , status : :unprocessable_entity
Original file line number Diff line number Diff line change @@ -464,6 +464,21 @@ class LevelsControllerTest < ActionController::TestCase
464
464
assert_equal 'original name' , level . name
465
465
end
466
466
467
+ test 'no error message when not actually changing level name' do
468
+ level = create :level , name : 'original name'
469
+
470
+ post :update , id : level . id , level : { name : 'original name' }
471
+
472
+ assert_response 200
473
+
474
+ # no error message
475
+ assert assigns ( :level ) . errors [ :name ] . blank?
476
+
477
+ level = level . reload
478
+ # same name
479
+ assert_equal 'original name' , level . name
480
+ end
481
+
467
482
test 'can update level name' do
468
483
level = create :level , name : 'original name'
469
484
You can’t perform that action at this time.
0 commit comments