Skip to content

Commit 5c13199

Browse files
committed
make getText/setText work for input, button, label, etc.
1 parent 72154e1 commit 5c13199

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

blockly/src/webapp/webapp.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,18 +1170,26 @@ Webapp.createTextLabel = function (opts) {
11701170

11711171
Webapp.getText = function (opts) {
11721172
var divWebapp = document.getElementById('divWebapp');
1173-
var div = document.getElementById(opts.elementId);
1174-
if (divWebapp.contains(div)) {
1175-
return String(div.value);
1173+
var element = document.getElementById(opts.elementId);
1174+
if (divWebapp.contains(element)) {
1175+
if (element.tagName === 'INPUT') {
1176+
return String(element.value);
1177+
} else {
1178+
return element.innerText;
1179+
}
11761180
}
11771181
return false;
11781182
};
11791183

11801184
Webapp.setText = function (opts) {
11811185
var divWebapp = document.getElementById('divWebapp');
1182-
var div = document.getElementById(opts.elementId);
1183-
if (divWebapp.contains(div)) {
1184-
div.value = opts.text;
1186+
var element = document.getElementById(opts.elementId);
1187+
if (divWebapp.contains(element)) {
1188+
if (element.tagName === 'INPUT') {
1189+
element.value = opts.text;
1190+
} else {
1191+
element.innerText = opts.text;
1192+
}
11851193
}
11861194
return false;
11871195
};

0 commit comments

Comments
 (0)