Skip to content

Commit 85729b4

Browse files
committed
Don't send report / show feedback on run when not in level builder
1 parent a839438 commit 85729b4

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

blockly/src/appMain.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@ module.exports = function(app, levels, options) {
7171
isK1: options.level && options.level.isK1
7272
};
7373

74-
if (options.level && options.level.edit_blocks) {
74+
BlocklyApps.isLevelBuilder = options.level && options.level.edit_blocks;
75+
76+
if (BlocklyApps.isLevelBuilder) {
7577
utils.wrapNumberValidatorsForLevelBuilder();
7678
}
7779

blockly/src/voxel/voxel.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ BlocklyApps.runButtonClick = function() {
156156
BlocklyApps.toggleRunReset('reset');
157157
Blockly.mainBlockSpace.traceOn(true);
158158
BlocklyApps.attempts++;
159-
Voxel.execute();
159+
// Only show feedback after run button click if we're in the level builder
160+
var shouldSendReportAndShowFeedback = BlocklyApps.isLevelBuilder;
161+
Voxel.execute(!shouldSendReportAndShowFeedback);
160162
};
161163

162164
/**
@@ -167,13 +169,20 @@ Voxel.resetButtonClick = function () {
167169

168170
};
169171

170-
Voxel.execute = function() {
172+
/**
173+
* @param noReportOrFeedback (optional) don't send report or feedback
174+
*/
175+
Voxel.execute = function(noReportOrFeedback) {
171176
Voxel.result = BlocklyApps.ResultType.UNSET;
172177
Voxel.testResults = BlocklyApps.TestResults.NO_TESTS_RUN;
173178
Voxel.message = undefined;
174179

175180
Voxel.evaluateCodeUnderBlockType('when_run');
176181

182+
if (noReportOrFeedback) {
183+
return;
184+
}
185+
177186
Voxel.testResults = BlocklyApps.getTestResults(Voxel.result);
178187

179188
if (level.freePlay) {

0 commit comments

Comments
 (0)