cleanup based on feedback

Author: wjordan

dashboard/app/controllers/levels_controller.rb

@@ -207,7 +207,6 @@ def embed_blocks
         baseUrl: "#{ActionController::Base.asset_host}/blockly/",
         blocks: @level.properties[@block_type]
     }
-    puts "blocks: #{@level[@block_type]}, block type=#{@block_type}"
     render :embed_blocks, layout: false
   end
 

dashboard/app/helpers/levels_helper.rb

@@ -287,11 +287,24 @@ def string_or_image(prefix, text)
       ext = File.extname(path)
       base_level = File.basename(path, ext)
       level = Level.find_by(name: base_level)
-      "<iframe src='#{url_for(:controller => :levels, :action => :embed_blocks, :level_id => level.id, :block_type => ext.tap{|x|x.slice!(0)}).strip}' width='#{width ? width.strip : '100%'}' scrolling='no' seamless='seamless' style='border: none;'></iframe>"
+      content_tag(:iframe, '', {
+          src: url_for(controller: :levels, action: :embed_blocks, level_id: level.id, block_type: ext.slice(1..-1)).strip,
+          width: width ? width.strip : '100%',
+          scrolling: 'no',
+          seamless: 'seamless',
+          style: 'border: none;',
+      })
     elsif File.extname(path) == '.level'
       base_level = File.basename(path, '.level')
       level = Level.find_by(name: base_level)
-      "<div class='aspect-ratio'><iframe src='#{url_for(:id => level.id, :controller => 'levels', :action => 'show', :embed => true).strip}' width='#{width ? width.strip : '100%'}' scrolling='no' seamless='seamless' style='border: none;'></iframe></div>"
+      content_tag(:div,
+        content_tag(:iframe, '', {
+          src: url_for(id: level.id, controller: :levels, action: :show, embed: true).strip,
+          width: (width ? width.strip : '100%'),
+          scrolling: 'no',
+          seamless: 'seamless',
+          style: 'border: none;'
+        }), {class: 'aspect-ratio'})
     else
       data_t(prefix + '.' + @level.name, text)
     end