more caching -- no reads of non-user specific data on logged in milestone post

Author: laurelfan

dashboard/app/models/level_source.rb

@@ -16,6 +16,7 @@ class LevelSource < ActiveRecord::Base
   XMLNS_STRING = ' xmlns="http://www.w3.org/1999/xhtml"'
 
   def LevelSource.cache_enabled?
+    @@cache_enabled ||= false
     rack_env?(:production) || @@cache_enabled
   end
 

dashboard/app/models/script.rb

@@ -2,8 +2,8 @@
 class Script < ActiveRecord::Base
   include Seeded
   has_many :levels, through: :script_levels
-  has_many :script_levels, -> { order('chapter ASC') }, dependent: :destroy # all script levels, even those w/ stages, are ordered by chapter, see Script#add_script
-  has_many :stages, -> { order('position ASC') }, dependent: :destroy
+  has_many :script_levels, -> { order('chapter ASC') }, dependent: :destroy, inverse_of: :script # all script levels, even those w/ stages, are ordered by chapter, see Script#add_script
+  has_many :stages, -> { order('position ASC') }, dependent: :destroy, inverse_of: :script
   belongs_to :wrapup_video, foreign_key: 'wrapup_video_id', class_name: 'Video'
   belongs_to :user
   validates :name, presence: true, uniqueness: { case_sensitive: false}
@@ -58,6 +58,10 @@ def cached?
         self.equal?(Script.playlab_script)
   end
 
+  def Script.should_be_cached?(id)
+    Script.script_cache.has_key?(id.to_s)
+  end
+
   def should_be_cached?
     Script.script_cache.has_key?(id.to_s)
   end

dashboard/app/models/script_level.rb

@@ -2,8 +2,8 @@
 # A Script has one or more Levels, and a Level can belong to one or more Scripts
 class ScriptLevel < ActiveRecord::Base
   belongs_to :level
-  belongs_to :script
-  belongs_to :stage
+  belongs_to :script, inverse_of: :script_levels
+  belongs_to :stage, inverse_of: :script_levels
   acts_as_list scope: :stage
 
   NEXT = 'next'
@@ -31,7 +31,16 @@ def or_next_progression_level
     valid_progression_level? ? self : next_progression_level
   end
 
+  def cached_valid_progression_level?
+    cached_script = Script.get_from_cache(script_id)
+    cached_script_level = cached_script.script_levels.to_a.find{|sl| sl.id == self.id}
+    return false if cached_script_level.level.unplugged?
+    return false if cached_script_level.stage && cached_script_level.stage.unplugged?
+    true
+  end
+
   def valid_progression_level?
+    return cached_valid_progression_level? if Script.should_be_cached?(script_id)
     return false if level.unplugged?
     return false if stage && stage.unplugged?
     true
@@ -103,7 +112,7 @@ def stage_or_game_total
   end
 
   def self.cache_find(id)
-    @@script_level_map ||= ScriptLevel.includes(:level, :script).index_by(&:id)
+    @@script_level_map ||= ScriptLevel.includes([{level: [:game, :concepts]}, :script]).index_by(&:id)
     @@script_level_map[id]
   end
 

dashboard/app/models/stage.rb

@@ -1,8 +1,8 @@
 # Ordered partitioning of script levels within a script
 # (Intended to replace most of the functionality in Game, due to the need for multiple app types within a single Game/Stage)
 class Stage < ActiveRecord::Base
-  has_many :script_levels, -> { order('position ASC') }
-  belongs_to :script
+  has_many :script_levels, -> { order('position ASC') }, inverse_of: :stage
+  belongs_to :script, inverse_of: :stages
   acts_as_list scope: :script
 
   validates_uniqueness_of :name, scope: :script_id

dashboard/app/models/user.rb

@@ -244,7 +244,10 @@ def levels_from_script(script, game_index=nil, stage=nil)
 
   def next_unpassed_progression_level(script)
     user_levels_by_level = self.user_levels.index_by(&:level_id)
-    script.script_levels.detect do |script_level|
+    cached_script = script
+    cached_script = Script.get_from_cache(script.id) if script.should_be_cached?
+    
+    cached_script.script_levels.detect do |script_level|
       user_level = user_levels_by_level[script_level.level_id]
       is_unpassed_progression_level(script_level, user_level)
     end

dashboard/app/models/user_script.rb

@@ -5,7 +5,7 @@ class UserScript < ActiveRecord::Base
   def check_completed?
     # the script is completed if there are no more "progression levels" to be completed
     # (unplugged levels are not progression levels, for one)
-    user.next_unpassed_progression_level(script).nil?
+    user.next_unpassed_progression_level(Script.get_from_cache(script_id)).nil?
   end
 
   def empty?

dashboard/config/environments/test.rb

@@ -45,5 +45,6 @@
   CDO.disable_s3_image_uploads = true
 
   # see stack traces around sql queries in the log
-  ActiveRecordQueryTrace.enabled = true
+  # off by default because it slows things down
+#  ActiveRecordQueryTrace.enabled = true
 end