Move auth stuff into beforeModel so we can use Ember events/models

Author: kleinsch

app/app_setup.js

@@ -3,87 +3,31 @@
 
 window.balancedSetupFunctions = [];
 
-
-function hackTheLogin () {
-    if (window.TESTING) {
-        return;
-    }
-
-    // TODO: refactor this nastiness.
-    // what happens is that ember-auth uses async: false which does not work in
-    // firefox. so instead, what we do is hack in auth **before** the app begins
-    // working. this means that if the user is already logged in then ember-auth
-    // is going to think that they are all good to go and the async: false
-    // won't break our flow.
-    window.Balanced.deferReadiness();
-
-    function fin () {
-        window.Balanced.advanceReadiness();
-    }
-
-    $.ajax({
-        type: 'POST',
-        url: Ember.ENV.BALANCED.AUTH,
-        xhrFields: {
-            withCredentials: true
-        }
-    }).success(function (r) {
-        var csrfToken = r.csrf;
-        Balanced.NET.ajaxHeaders['X-CSRFToken'] = csrfToken;
-        var authCookie = Balanced.Auth.retrieveLogin();
-        if (authCookie) {
-            $.ajax('https://auth.balancedpayments.com/logins', {
-                type: 'POST',
-                xhrFields: {
-                    withCredentials: true
-                },
-                data: { uri: authCookie }
-            }).success(function (login) {
-                Balanced.Analytics.trackEvent('login-success', {remembered: true});
-
-                // set the auth stuff manually
-                Balanced.Auth.setAuthProperties(
-                    true,
-                    Balanced.User.find(login.user_uri),
-                    login.user_id,
-                    login.user_id,
-                    false
-                );
-                fin();
-            }).error(fin);
-        } else {
-            fin();
-        }
-    }).error(fin);
-}
-
 /*
- Creates a new instance of an Ember application and
- specifies what HTML element inside index.html Ember
- should manage for you.
- */
+Creates a new instance of an Ember application and
+specifies what HTML element inside index.html Ember
+should manage for you.
+*/
 window.setupBalanced = function (divSelector) {
 
-    // default to #balanced-app if not specified
-    divSelector = divSelector || '#balanced-app';
-    window.Balanced = Ember.Application.create({
-        rootElement: divSelector,
-        LOG_TRANSITIONS: true,
-
-        customEvents: {
-            // key is the jquery event, value is the name used in views
-            changeDate: 'changeDate'
-        }
-    });
-
-    hackTheLogin();
-
-    window.Balanced.onLoad = function () {
-        //  initialize anything that needs to be done on application load
-        Balanced.Analytics.init(Ember.ENV.BALANCED);
-    };
-
-    _.each(window.balancedSetupFunctions, function (setupFunction) {
-        setupFunction();
-    });
+	// default to #balanced-app if not specified
+	divSelector = divSelector || '#balanced-app';
+	window.Balanced = Ember.Application.create({
+		rootElement: divSelector,
+		LOG_TRANSITIONS: true,
+
+		customEvents: {
+			// key is the jquery event, value is the name used in views
+			changeDate: 'changeDate'
+		}
+	});
+
+	window.Balanced.onLoad = function () {
+		//  initialize anything that needs to be done on application load
+		Balanced.Analytics.init(Ember.ENV.BALANCED);
+	};
+
+	_.each(window.balancedSetupFunctions, function (setupFunction) {
+		setupFunction();
+	});
 };

app/routes/application.js

@@ -1,4 +1,43 @@
 Balanced.ApplicationRoute = Balanced.Route.extend({
+	beforeModel: function() {
+		if (window.TESTING || Balanced.Auth.get('signedIn')) {
+			return;
+		}
+
+		var self = this;
+
+		return $.ajax({
+			type: 'POST',
+			url: Ember.ENV.BALANCED.AUTH,
+			xhrFields: {
+				withCredentials: true
+			}
+		}).then(function(response, status, jqxhr) {
+			var csrfToken = response.csrf;
+			Balanced.NET.ajaxHeaders['X-CSRFToken'] = csrfToken;
+
+			var authCookie = Balanced.Auth.retrieveLogin();
+			if (authCookie) {
+				return $.ajax('https://auth.balancedpayments.com/logins', {
+					type: 'POST',
+					xhrFields: {
+						withCredentials: true
+					},
+					data: { uri: authCookie }
+				}).success(function (response, status, jqxhr) {
+					// set the auth stuff manually
+					Balanced.Auth.setAuthProperties(
+						true,
+						Balanced.User.find(response.user_uri),
+						response.user_id,
+						response.user_id,
+						false
+					);
+				});
+			}
+		});
+	},
+
 	events: {
 		error: function(error, transition) {
 			Ember.Logger.error("Error while loading route (%@: %@): ".fmt(error.errorStatusCode, error.uri), error.stack || error);