Print bool tensor properly (tensorflow#1612)

BUG

Print boolean tensor properly.
See: tensorflow/tfjs#1222

Author: Lewuathe

src/tensor_format.ts

@@ -58,27 +58,35 @@ function computeMaxSizePerColumn(
       const offset = row * numCols;
       for (let j = 0; j < numCols; j++) {
         padPerCol[j] = Math.max(
-            padPerCol[j], valToString(valuesOrTuples[offset + j], 0).length);
+            padPerCol[j], valToString(valuesOrTuples[offset + j], 0,
+              dtype).length);
       }
     }
   }
   return padPerCol;
 }
 
-function valToString(val: number|string|[number, number], pad: number) {
+function valToString(val: number|string|[number, number], pad: number,
+    dtype: DataType) {
   let valStr: string;
   if (Array.isArray(val)) {
     valStr = `${parseFloat(val[0].toFixed(FORMAT_NUM_SIG_DIGITS))} + ` +
         `${parseFloat(val[1].toFixed(FORMAT_NUM_SIG_DIGITS))}j`;
   } else if (isString(val)) {
     valStr = `'${val}'`;
+  } else if (dtype === 'bool') {
+    valStr = boolNumToString(val);
   } else {
     valStr = parseFloat(val.toFixed(FORMAT_NUM_SIG_DIGITS)).toString();
   }
 
   return rightPad(valStr, pad);
 }
 
+function boolNumToString(v: number): string {
+  return v === 0 ? 'false' : 'true';
+}
+
 function subTensorToString(
     vals: TypedArray|string[], shape: number[], dtype: DataType,
     strides: number[], padPerCol: number[], isLast = true): string[] {
@@ -89,7 +97,10 @@ function subTensorToString(
   if (rank === 0) {
     if (dtype === 'complex64') {
       const complexTuple = createComplexTuples(vals);
-      return [valToString(complexTuple[0], 0)];
+      return [valToString(complexTuple[0], 0, dtype)];
+    }
+    if (dtype === 'bool') {
+      return [boolNumToString(vals[0] as number)];
     }
     return [vals[0].toString()];
   }
@@ -107,12 +118,13 @@ function subTensorToString(
         lastVals = createComplexTuples(lastVals);
       }
       return [
-        '[' + firstVals.map((x, i) => valToString(x, padPerCol[i])).join(', ') +
+        '[' + firstVals.map((x, i) => valToString(x, padPerCol[i],
+          dtype)).join(', ') +
         ', ..., ' +
         lastVals
             .map(
                 (x, i) => valToString(
-                    x, padPerCol[size - FORMAT_NUM_FIRST_LAST_VALS + i]))
+                    x, padPerCol[size - FORMAT_NUM_FIRST_LAST_VALS + i], dtype))
             .join(', ') +
         ']'
       ];
@@ -122,7 +134,8 @@ function subTensorToString(
                                 Array.from<number|string>(vals);
 
     return [
-      '[' + displayVals.map((x, i) => valToString(x, padPerCol[i])).join(', ') +
+      '[' + displayVals.map((x, i) => valToString(x, padPerCol[i],
+        dtype)).join(', ') +
       ']'
     ];
   }

src/tensor_test.ts

@@ -1443,6 +1443,18 @@ describe('tensor.toString', () => {
         '    test');
   });
 
+  it('bool scalar verbose', () => {
+    const verbose = true;
+    const str = tf.scalar(true).toString(verbose);
+    expect(str).toEqual(
+      'Tensor\n' +
+      '  dtype: bool\n' +
+      '  rank: 0\n' +
+      '  shape: []\n' +
+      '  values:\n' +
+      '    true');
+  });
+
   it('1d tensor verbose', () => {
     const verbose = true;
     const str = tf.zeros([4]).toString(verbose);
@@ -1467,6 +1479,18 @@ describe('tensor.toString', () => {
         '    [\'a\', \'bb\', \'ccc\']');
   });
 
+  it('1d bool tensor verbose', () => {
+    const verbose = true;
+    const str = tf.tensor([true, false, true]).toString(verbose);
+    expect(str).toEqual(
+        'Tensor\n' +
+        '  dtype: bool\n' +
+        '  rank: 1\n' +
+        '  shape: [3]\n' +
+        '  values:\n' +
+        '    [true, false, true]');
+  });
+
   it('2d tensor verbose', () => {
     const verbose = true;
     const str = tf.zeros([3, 3]).toString(verbose);
@@ -1500,6 +1524,20 @@ describe('tensor.toString', () => {
         '     [\'g\', \'h\' , \'i\'  ]]');
   });
 
+  it('2d bool tensor verbose', () => {
+    const verbose = true;
+    const str = tf.zeros([3, 3], 'bool').toString(verbose);
+    expect(str).toEqual(
+        'Tensor\n' +
+        '  dtype: bool\n' +
+        '  rank: 2\n' +
+        '  shape: [3,3]\n' +
+        '  values:\n' +
+        '    [[false, false, false],\n' +
+        '     [false, false, false],\n' +
+        '     [false, false, false]]');
+  });
+
   it('3d tensor verbose', () => {
     const verbose = true;
     const str = tf.zeros([3, 3, 2]).toString(verbose);
@@ -1542,6 +1580,26 @@ describe('tensor.toString', () => {
         '      [\'kkk\', \'llll\']]]');
   });
 
+  it('3d bool tensor verbose', () => {
+    const verbose = true;
+    const str = tf.ones([3, 3, 2], 'bool').toString(verbose);
+    expect(str).toEqual(
+        'Tensor\n' +
+        '  dtype: bool\n' +
+        '  rank: 3\n' +
+        '  shape: [3,3,2]\n' +
+        '  values:\n' +
+        '    [[[true, true],\n' +
+        '      [true, true],\n' +
+        '      [true, true]],\n\n' +
+        '     [[true, true],\n' +
+        '      [true, true],\n' +
+        '      [true, true]],\n\n' +
+        '     [[true, true],\n' +
+        '      [true, true],\n' +
+        '      [true, true]]]');
+  });
+
   it('1d long tensor verbose', () => {
     const verbose = true;
     const str = tf.zeros([100]).toString(verbose);