detect xania glitch

Author: krausest

webdriver-ts/src/benchmarkRunner.ts

@@ -135,7 +135,9 @@ async function runBenchmakLoop(
     let res = await forkAndCallBenchmark(framework, benchmarkInfo, benchmarkOptions);
     if (Array.isArray(res.result)) {
       results = results.concat(res.result as number[]|CPUBenchmarkResult[]);
-    } else results.push(res.result);
+    } else if (res.result !==undefined) {
+      results.push(res.result);
+    }
     warnings = warnings.concat(res.warnings);
     if (res.error) {
       if (res.error.indexOf("Server terminated early with status 1") > -1) {

webdriver-ts/src/benchmarksPlaywright.ts

@@ -4,7 +4,7 @@ import { Browser, Page } from "playwright-core";
 import * as benchmarksCommon from "./benchmarksCommon.js";
 import { BenchmarkType } from "./benchmarksCommon.js";
 import { BenchmarkOptions, config, FrameworkData } from "./common.js";
-import { checkElementContainsText, checkElementExists, checkElementHasClass, checkElementNotExists, clickElement } from "./playwrightAccess.js";
+import { checkCountForSelector, checkElementContainsText, checkElementExists, checkElementHasClass, checkElementNotExists, clickElement } from "./playwrightAccess.js";
 
 
 export abstract class CPUBenchmarkPlaywright implements benchmarksCommon.BenchmarkImpl {
@@ -91,6 +91,7 @@ export const benchSelect = new class extends CPUBenchmarkPlaywright {
     for (let i = 0; i <= config.WARMUP_COUNT; i++) {
       await clickElement(page, `tbody>tr:nth-of-type(${i+5})>td:nth-of-type(2)>a`);
       await checkElementHasClass(page, `tbody>tr:nth-of-type(${i+5})`, "danger");
+      await checkCountForSelector(page, "tbody>tr.danger", 1);
     }
   }
   async run(browser: Browser,page: Page) {

webdriver-ts/src/benchmarksPuppeteer.ts

@@ -4,7 +4,7 @@ import { Page } from "puppeteer-core";
 import * as benchmarksCommon from "./benchmarksCommon.js";
 import { BenchmarkType } from "./benchmarksCommon.js";
 import { BenchmarkOptions, config, FrameworkData } from "./common.js";
-import { checkElementContainsText, checkElementExists, checkElementHasClass, checkElementNotExists, clickElement } from "./puppeteerAccess.js";
+import { checkCountForSelector, checkElementContainsText, checkElementExists, checkElementHasClass, checkElementNotExists, clickElement } from "./puppeteerAccess.js";
 
 
 export abstract class CPUBenchmarkPuppeteer implements benchmarksCommon.BenchmarkImpl {
@@ -92,6 +92,7 @@ export const benchSelect = new class extends CPUBenchmarkPuppeteer {
     for (let i = 0; i <= config.WARMUP_COUNT; i++) {
       await clickElement(page, `pierce/tbody>tr:nth-of-type(${i+5})>td:nth-of-type(2)>a`);
       await checkElementHasClass(page, `pierce/tbody>tr:nth-of-type(${i+5})`, "danger");
+      await checkCountForSelector(page, "pierce/tbody>tr.danger", 1);
     }
   }
   async run(page: Page) {

webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts

@@ -85,12 +85,7 @@ async function runCPUBenchmark(framework: FrameworkData, benchmark: CPUBenchmark
                 //     uploadThroughput: 330 * 1024 / 8, // 330 kb/s
                 // });
             console.log("initBenchmark");
-            try {
-              await initBenchmark(page, benchmark, framework);
-            } catch (ex) {
-              console.log("**** initBenchmark failed, retrying");
-              await initBenchmark(page, benchmark, framework);
-            }
+            await initBenchmark(page, benchmark, framework);
 
             let categories = [
                 "blink.user_timing",

webdriver-ts/src/playwrightAccess.ts

@@ -79,6 +79,19 @@ export async function checkElementHasClass(page: Page, selector: string, classNa
   throw `checkElementHasClass ${selector} failed. expected ${className}, but was ${clazzes}`;
 }
 
+export async function checkCountForSelector(page: Page, selector: string, expectedCount: number): Promise<void> {
+  let elems = await page.$$(selector);
+  if (elems) {
+    if (expectedCount!==elems.length) {
+      throw `checkCountForSelector ${selector} failed. expected ${expectedCount}, but ${elems.length} were found`;
+    }
+  } else {
+    if (expectedCount!==0) {
+      throw `checkCountForSelector ${selector} failed. expected ${expectedCount}, but selector was not found`;
+    }
+  }
+}
+
 function browserPath(benchmarkOptions: BenchmarkOptions) {
   if (benchmarkOptions.chromeBinaryPath) return benchmarkOptions.chromeBinaryPath;
   if (process.platform == "darwin") {

webdriver-ts/src/puppeteerAccess.ts

@@ -79,6 +79,19 @@ export async function checkElementHasClass(page: Page, selector: string, classNa
   throw `checkElementHasClass ${selector} failed. expected ${className}, but was ${clazzes}`;
 }
 
+export async function checkCountForSelector(page: Page, selector: string, expectedCount: number): Promise<void> {
+  let elems = await page.$$(selector);
+  if (elems) {
+    if (expectedCount!==elems.length) {
+      throw `checkCountForSelector ${selector} failed. expected ${expectedCount}, but ${elems.length} were found`;
+    }
+  } else {
+    if (expectedCount!==0) {
+      throw `checkCountForSelector ${selector} failed. expected ${expectedCount}, but selector was not found`;
+    }
+  }
+}
+
 function browserPath(benchmarkOptions: BenchmarkOptions) {
   if (benchmarkOptions.chromeBinaryPath) return benchmarkOptions.chromeBinaryPath;
   if (process.platform == "darwin") {