fix: status condition update (#88)

Author: aaronschweig

controller/lifecycle/lifecycle.go

@@ -250,21 +250,15 @@ func updateStatus(ctx context.Context, cl client.Client, original runtime.Object
 		return err
 	}
 
-	currentStatus, hasField, err := unstructured.NestedFieldCopy(currentUn, "status")
+	currentStatus, _, err := unstructured.NestedFieldCopy(currentUn, "status")
 	if err != nil {
 		return err
 	}
-	if !hasField {
-		return fmt.Errorf("status field not found in current object")
-	}
 
-	originalStatus, hasField, err := unstructured.NestedFieldCopy(originalUn, "status")
+	originalStatus, _, err := unstructured.NestedFieldCopy(originalUn, "status")
 	if err != nil {
 		return err
 	}
-	if !hasField {
-		return fmt.Errorf("status field not found in current object")
-	}
 
 	if equality.Semantic.DeepEqual(currentStatus, originalStatus) {
 		log.Info().Msg("skipping status update, since they are equal")

controller/lifecycle/lifecycle_test.go

@@ -894,7 +894,7 @@ func TestUpdateStatus(t *testing.T) {
 
 		// Then
 		assert.Error(t, err)
-		assert.Equal(t, "status field not found in current object", err.Error())
+		assert.Equal(t, "internal error", err.Error())
 	})
 	t.Run("Test UpdateStatus with no status object (current)", func(t *testing.T) {
 		original := &pmtesting.ImplementConditions{}
@@ -904,7 +904,7 @@ func TestUpdateStatus(t *testing.T) {
 
 		// Then
 		assert.Error(t, err)
-		assert.Equal(t, "status field not found in current object", err.Error())
+		assert.Equal(t, "internal error", err.Error())
 	})
 }