Skip to content

Commit 2507be9

Browse files
bmaranvillegvwilson
authored andcommitted
add DataValidator to autogenerated instances provided by ValidatorCache, and cleanup
1 parent 44f7a4e commit 2507be9

File tree

1 file changed

+6
-29
lines changed

1 file changed

+6
-29
lines changed

codegen/__init__.py

Lines changed: 6 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@
2121
build_from_imports_py,
2222
)
2323
from codegen.validators import (
24-
write_validator_py,
24+
get_data_validator_params,
2525
get_validator_params,
2626
write_validator_json,
27-
write_data_validator_py,
2827
get_data_validator_instance,
2928
)
3029

@@ -178,23 +177,22 @@ def perform_codegen(reformat=True):
178177
# --------------------
179178
# # ### Layout ###
180179
for node in all_layout_nodes:
181-
# write_validator_py(outdir, node)
182180
get_validator_params(node, validator_params)
183181

184182
# ### Trace ###
185183
for node in all_trace_nodes:
186-
# write_validator_py(outdir, node)
187184
get_validator_params(node, validator_params)
188185

189186
# ### Frames ###
190187
for node in all_frame_nodes:
191-
# write_validator_py(outdir, node)
192188
get_validator_params(node, validator_params)
193-
189+
190+
# ### Data (traces) validator ###
191+
get_data_validator_params(base_traces_node, validator_params)
192+
193+
# Write out the JSON data for the validators
194194
os.makedirs(validators_pkgdir, exist_ok=True)
195195
write_validator_json(outdir, validator_params)
196-
# ### Data (traces) validator ###
197-
write_data_validator_py(outdir, base_traces_node)
198196

199197
# Alls
200198
# ----
@@ -225,27 +223,6 @@ def perform_codegen(reformat=True):
225223
layout_array_nodes,
226224
)
227225

228-
# Write validator __init__.py files
229-
# ---------------------------------
230-
# ### Write __init__.py files for each validator package ###
231-
validator_rel_class_imports = {}
232-
for node in all_datatype_nodes:
233-
if node.is_mapped:
234-
continue
235-
key = node.parent_path_parts
236-
validator_rel_class_imports.setdefault(key, []).append(
237-
f"._{node.name_property}.{node.name_validator_class}"
238-
)
239-
240-
# Add Data validator
241-
root_validator_pairs = validator_rel_class_imports[()]
242-
root_validator_pairs.append("._data.DataValidator")
243-
244-
# Output validator __init__.py files
245-
validators_pkg = opath.join(outdir, "validators")
246-
# for path_parts, rel_classes in validator_rel_class_imports.items():
247-
# write_init_py(validators_pkg, path_parts, [], rel_classes)
248-
249226
# Write datatype __init__.py files
250227
# --------------------------------
251228
datatype_rel_class_imports = {}

0 commit comments

Comments
 (0)