Remove check about being in an IO thread

Author: Stephane Landelle

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/Constants.java

@@ -4,9 +4,6 @@
 
 public class Constants {
 
-    // FIXME move into a state class along with closed
-    public static final ThreadLocal<Boolean> IN_IO_THREAD = new ThreadLocalBoolean();
-    
     // FIXME what to do with this???
     public final static int MAX_BUFFERED_BYTES = 8192;
 

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/NettyChannelHandler.java

@@ -77,8 +77,6 @@ public NettyChannelHandler(AsyncHttpClientConfig config, NettyRequestSender requ
     @Override
     public void channelRead(final ChannelHandlerContext ctx, Object e) throws Exception {
 
-        Constants.IN_IO_THREAD.set(Boolean.TRUE);
-
         Object attribute = Channels.getDefaultAttribute(ctx);
 
         if (attribute instanceof Callback) {

providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/NettyRequestSender.java

@@ -218,13 +218,8 @@ public <T> ListenableFuture<T> doConnect(final Request request, final AsyncHandl
             return cl.future();
         }
 
-        // FIXME when can we have a direct invokation???
-        // boolean directInvokation = !(IN_IO_THREAD.get() &&
-        // DefaultChannelFuture.isUseDeadLockChecker());
-        boolean directInvokation = !Constants.IN_IO_THREAD.get();
-
         // FIXME what does it have to do with the presence of a file?
-        if (directInvokation && !asyncConnect && request.getFile() == null) {
+        if (!asyncConnect && request.getFile() == null) {
             int timeOut = config.getConnectionTimeoutInMs() > 0 ? config.getConnectionTimeoutInMs() : Integer.MAX_VALUE;
             if (!channelFuture.awaitUninterruptibly(timeOut, TimeUnit.MILLISECONDS)) {
                 if (acquiredConnection) {