H002 perf #365

Author: Oleg

resources/checks/H002_unused_indexes.sh

@@ -213,10 +213,6 @@ index_data as (
     and  am1.amname = am2.amname -- same access type
     and i1.columns like (i2.columns || '%') -- index 2 includes all columns from index 1
     and i1.opclasses like (i2.opclasses || '%')
-    -- index expressions is same
-    and pg_get_expr(i1.indexprs, i1.indrelid) is not distinct from pg_get_expr(i2.indexprs, i2.indrelid)
-    -- index predicates is same
-    and pg_get_expr(i1.indpred, i1.indrelid) is not distinct from pg_get_expr(i2.indpred, i2.indrelid)
 ), redundant_indexes_fk as (
   select
     ri.*,
@@ -225,6 +221,8 @@ index_data as (
   left join fk_indexes fi on
     fi.fk_table_ref = ri.table_name
     and fi.opclasses like (ri.opclasses || '%')
+  where substring(ri.main_index_def from position('USING' in ri.main_index_def) for length(ri.main_index_def)) = 
+	substring(ri.index_def from position('USING' in ri.index_def) for length(ri.index_def))
 ),
 -- Cut recursive links
 redundant_indexes_tmp_num as (

run_tests.sh

@@ -12,6 +12,37 @@ su - postgres -c "psql -A -t -d postgres -c 'DROP DATABASE if exists ${db_name}'
 su - postgres -c "psql -A -t -d postgres -c 'CREATE DATABASE ${db_name}'"
 su - postgres -c "psql -A -t -d ${db_name} -f "${current_dir}"/.ci/test_db_dump.sql"
 
+# ---------------------------------------------------------------------------------------------
+echo "=======> Test started: H002_unused_indexes.sh"
+test_resut=1
+
+rm -Rf ./artifacts
+./checkup -h 127.0.0.1 --username postgres --project test --dbname ${db_name} -e 1 \
+	--file ./resources/checks/H002_unused_indexes.sh
+
+data_dir=$(cat ./artifacts/test/nodes.json | jq -r '.last_check | .dir') \
+	&& result=$(cat ./artifacts/test/json_reports/$data_dir/H002_unused_indexes.json | 
+		jq '.results ."127.0.0.1" .data .redundant_indexes ."public.t_with_redundant_idx_id"') \
+	&& ([[ "$result" == "[]" ]] || [[ "$result" == "null" ]]) \
+	&& echo "ERROR in H002: ${result} in '.results .\"127.0.0.1\" .data .redundant_indexes .\"public.t_with_redundant_idx_id\"'" \
+	&& echo $(cat ./artifacts/test/json_reports/$data_dir/H002_unused_indexes.json | jq '.') \
+	&& test_resut=0
+
+data_dir=$(cat ./artifacts/test/nodes.json | jq -r '.last_check | .dir') \
+	&& result=$(cat ./artifacts/test/json_reports/$data_dir/H002_unused_indexes.json | 
+		jq '.results ."127.0.0.1" .data .redundant_indexes ."public.t_with_redundant_idx_f1_uniq"') \
+	&& ([[ ! "$result" == "[]" ]] && [[ ! "$result" == "null" ]]) \
+	&& echo "ERROR in H002: ${result} in '.results .\"127.0.0.1\" .data .redundant_indexes .\"public.t_with_redundant_idx_f1_uniq\"'" \
+	&& echo $(cat ./artifacts/test/json_reports/$data_dir/H002_unused_indexes.json | jq '.') \
+	&& test_resut=0
+
+if [ "$test_resut" -eq "1" ]; then
+	echo "<======= Test finished: H002"
+else
+	echo "<======= Test failed: H002"
+fi
+
+# ---------------------------------------------------------------------------------------------
 echo "=======> Test started: H003 Non indexed FKs"
 test_resut=1
 su - postgres -c "psql -A -t -d ${db_name} -f "${current_dir}"/.ci/h003_step_1.sql"
@@ -47,3 +78,4 @@ if [ "$test_resut" -eq "1" ]; then
 else
 	echo "<======= Test failed: H003"
 fi
+# ---------------------------------------------------------------------------------------------