Update styles to match BFE

Author: Will Sabransky

packages/eslint-config-base/rules/best-practices.js

@@ -26,7 +26,7 @@ module.exports = {
     curly: ['error', 'multi-line'],
 
     // require default case in switch statements
-    'default-case': ['error', { commentPattern: '^no default$' }],
+    'default-case': 'off',
 
     // encourages use of dot notation whenever possible
     'dot-notation': ['error', { allowKeywords: true }],
@@ -260,7 +260,7 @@ module.exports = {
     'no-sequences': 'error',
 
     // restrict what can be thrown as an exception
-    'no-throw-literal': 'error',
+    'no-throw-literal': 'off',
 
     // disallow unmodified conditions of loops
     // https://eslint.org/docs/rules/no-unmodified-loop-condition

packages/eslint-config-base/rules/errors.js

@@ -93,7 +93,7 @@ module.exports = {
 
     // disallow use of Object.prototypes builtins directly
     // https://eslint.org/docs/rules/no-prototype-builtins
-    'no-prototype-builtins': 'error',
+    'no-prototype-builtins': 'off',
 
     // disallow multiple spaces in a regular expression literal
     'no-regex-spaces': 'error',

packages/eslint-config-base/rules/es6.js

@@ -21,9 +21,7 @@ module.exports = {
 
     // require parens in arrow function arguments
     // https://eslint.org/docs/rules/arrow-parens
-    'arrow-parens': ['error', 'as-needed', {
-      requireForBlockBody: true,
-    }],
+    'arrow-parens': 'off',
 
     // require space before/after arrow function's arrow
     // https://eslint.org/docs/rules/arrow-spacing

packages/eslint-config-base/rules/imports.js

@@ -69,28 +69,7 @@ module.exports = {
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md
     // paths are treated both as absolute paths, and relative to process.cwd()
     'import/no-extraneous-dependencies': ['error', {
-      devDependencies: [
-        'test/**', // tape, common npm pattern
-        'tests/**', // also common npm pattern
-        'spec/**', // mocha, rspec-like pattern
-        '**/__tests__/**', // jest pattern
-        '**/__mocks__/**', // jest pattern
-        'test.{js,jsx}', // repos with a single test file
-        'test-*.{js,jsx}', // repos with multiple top-level test files
-        '**/*{.,_}{test,spec}.{js,jsx}', // tests where the extension or filename suffix denotes that it is a test
-        '**/jest.config.js', // jest config
-        '**/vue.config.js', // vue-cli config
-        '**/webpack.config.js', // webpack config
-        '**/webpack.config.*.js', // webpack config
-        '**/rollup.config.js', // rollup config
-        '**/rollup.config.*.js', // rollup config
-        '**/gulpfile.js', // gulp config
-        '**/gulpfile.*.js', // gulp config
-        '**/Gruntfile{,.js}', // grunt config
-        '**/protractor.conf.js', // protractor config
-        '**/protractor.conf.*.js', // protractor config
-      ],
-      optionalDependencies: false,
+      devDependencies: ['**/*{.,_}{test,spec}.{js,jsx,ts,tsx}'],
     }],
 
     // Forbid mutable exports
@@ -134,10 +113,11 @@ module.exports = {
 
     // Ensure consistent use of file extension within the import path
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
-    'import/extensions': ['error', 'ignorePackages', {
+    'import/extensions': ['error', 'always', {
       js: 'never',
-      mjs: 'never',
       jsx: 'never',
+      ts: 'never',
+      tsx: 'never',
     }],
 
     // ensure absolute imports are above relative imports and that unassigned imports are ignored
@@ -184,7 +164,7 @@ module.exports = {
 
     // Forbid Webpack loader syntax in imports
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-webpack-loader-syntax.md
-    'import/no-webpack-loader-syntax': 'error',
+    'import/no-webpack-loader-syntax': 'off',
 
     // Prevent unassigned imports
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unassigned-import.md

packages/eslint-config-base/rules/style.js

@@ -273,7 +273,7 @@ module.exports = {
 
     // disallow use of the continue statement
     // https://eslint.org/docs/rules/no-continue
-    'no-continue': 'error',
+    'no-continue': 'off',
 
     // disallow comments inline after code
     'no-inline-comments': 'off',
@@ -331,25 +331,7 @@ module.exports = {
 
     // disallow certain syntax forms
     // https://eslint.org/docs/rules/no-restricted-syntax
-    'no-restricted-syntax': [
-      'error',
-      {
-        selector: 'ForInStatement',
-        message: 'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
-      },
-      {
-        selector: 'ForOfStatement',
-        message: 'iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.',
-      },
-      {
-        selector: 'LabeledStatement',
-        message: 'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
-      },
-      {
-        selector: 'WithStatement',
-        message: '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
-      },
-    ],
+    'no-restricted-syntax': 'off',
 
     // disallow space between function identifier and application
     'no-spaced-func': 'error',

packages/eslint-config/index.js

@@ -4,6 +4,7 @@ module.exports = {
     '@postmates/eslint-config-base/rules/strict',
     './rules/react',
     './rules/react-a11y',
+    './rules/typescript',
   ].map(require.resolve),
   rules: {}
 };

packages/eslint-config/package.json

@@ -55,13 +55,15 @@
     "in-publish": "^2.0.0",
     "react": ">= 0.13.0",
     "safe-publish-latest": "^1.1.2",
-    "tape": "^4.9.1"
+    "tape": "^4.9.1",
+    "typescript-eslint-parser": "^21.0.2"
   },
   "peerDependencies": {
     "eslint": "^4.19.1 || ^5.3.0",
     "eslint-plugin-import": "^2.14.0",
     "eslint-plugin-jsx-a11y": "^6.1.1",
-    "eslint-plugin-react": "^7.10.0"
+    "eslint-plugin-react": "^7.10.0",
+    "typescript-eslint-parser": "^21.0.2"
   },
   "engines": {
     "node": ">= 4"

packages/eslint-config/rules/react.js

@@ -227,47 +227,7 @@ module.exports = {
 
     // Enforce component methods order
     // https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/sort-comp.md
-    'react/sort-comp': ['error', {
-      order: [
-        'static-methods',
-        'instance-variables',
-        'lifecycle',
-        '/^on.+$/',
-        'getters',
-        'setters',
-        '/^(get|set)(?!(InitialState$|DefaultProps$|ChildContext$)).+$/',
-        'instance-methods',
-        'everything-else',
-        'rendering',
-      ],
-      groups: {
-        lifecycle: [
-          'displayName',
-          'propTypes',
-          'contextTypes',
-          'childContextTypes',
-          'mixins',
-          'statics',
-          'defaultProps',
-          'constructor',
-          'getDefaultProps',
-          'getInitialState',
-          'state',
-          'getChildContext',
-          'componentWillMount',
-          'componentDidMount',
-          'componentWillReceiveProps',
-          'shouldComponentUpdate',
-          'componentWillUpdate',
-          'componentDidUpdate',
-          'componentWillUnmount',
-        ],
-        rendering: [
-          '/^render.+$/',
-          'render'
-        ],
-      },
-    }],
+    'react/sort-comp': 'off',
 
     // Prevent missing parentheses around multilines JSX
     // https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/jsx-wrap-multilines.md
@@ -299,7 +259,7 @@ module.exports = {
 
     // only .jsx files may have JSX
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
-    'react/jsx-filename-extension': ['error', { extensions: ['.jsx'] }],
+    'react/jsx-filename-extension': ['error', { extensions: ['.jsx', '.tsx'] }],
 
     // prevent accidental JS comments from being injected into JSX as text
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-comment-textnodes.md
@@ -339,7 +299,7 @@ module.exports = {
 
     // Require style prop value be an object or var
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/style-prop-object.md
-    'react/style-prop-object': 'error',
+    'react/style-prop-object': 'off',
 
     // Prevent invalid characters from appearing in markup
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unescaped-entities.md
@@ -365,7 +325,7 @@ module.exports = {
 
     // Prevent usage of Array index in keys
     // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-array-index-key.md
-    'react/no-array-index-key': 'warn',
+    'react/no-array-index-key': 'off',
 
     // Enforce a defaultProps definition for every prop that is not a required prop
     // https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/require-default-props.md

packages/eslint-config/rules/typescript.js

@@ -0,0 +1,31 @@
+module.exports = {
+  env: {
+    typescript: true
+  },
+
+  overrides: [{
+    parser: 'typescript-eslint-parser',
+    files: ['*.ts', '*.tsx'],
+    rules: {
+      'no-useless-constructor': 'off',
+      'no-undef': 'off',
+      'no-unused-vars': 'off',
+      'typescript/no-unused-vars': 'off',
+      'react/prop-types': 'off',
+      'no-param-reassign': 'off',
+      'space-infix-ops': 'off',
+      'import/export': 'off',
+      'import/no-duplicates': 'off',
+      'no-use-before-define': 'off',
+      'no-shadow': 'off',
+      'require-yield': 'off',
+      'consistent-return': 'off',
+
+      'arrow-parens': 'error',
+      'typescript/adjacent-overload-signatures': 'error',
+      'typescript/member-delimiter-style': 'error',
+      'typescript/no-angle-bracket-type-assertion': 'error',
+      'typescript/type-annotation-spacing': 'error',
+    }
+  }]
+};