Bumped version to 4.4. Improved sensitivity of PULSE_DISTANCE + PULSE_WIDTH protocols. New functions decodePulseDistanceWidthData() with 6 parameters and decodePulseDistanceWidthDataStrict() with 7 parameter.

Author: ArminJo

README.md

@@ -2,10 +2,13 @@
 The latest version may not be released!
 See also the commit log at github: https://github.com/Arduino-IRremote/Arduino-IRremote/commits/master
 
-# 4.3.3
+# 4.4.0
 - sendNEC() and sendNEC2() now accepts 16 bit command to better map to NECext protocol found in IRDB databases.
 - ir_DistanceWidthProtocol() now decodes up to 10 ms mark or spaces if RAM is bigger than 2 k.
+- Improved sensitivity and decoding of PULSE_DISTANCE + PULSE_WIDTH protocols.
+- Changed TOLERANCE_FOR_DECODERS_MARK_OR_SPACE_MATCHING to TOLERANCE_FOR_DECODERS_MARK_OR_SPACE_MATCHING_PERCENT.
 - Improved examples AllProtocolsOnLCD, UnitTest and SimpleReceiver.
+- New functions decodePulseDistanceWidthData() with 6 parameters and decodePulseDistanceWidthDataStrict() with 7 parameters.
 
 # 4.3.2
 - Added sendSonyMSB(unsigned long data, int nbits) as a clone of sendSony(unsigned long data, int nbits) to be more consistent.

changelog.md

@@ -762,6 +762,9 @@ float getCPUTemperatureSimple(void) {
 #if defined(__AVR_ATmega328PB__)
     tTemperatureRaw -= 245;
     return (float)tTemperatureRaw;
+#elif defined(__AVR_ATtiny85__)
+    tTemperatureRaw -= 273; // 273 and 1.1666 are values from the datasheet
+    return (float)tTemperatureRaw / 1.1666;
 #else
     tTemperatureRaw -= 317;
     return (float) tTemperatureRaw / 1.22;

examples/AllProtocolsOnLCD/ADCUtils.hpp

@@ -197,7 +197,7 @@ void dumpPulseParams() {
     ;
     Serial.println(F(" uSecs"));
     Serial.print(F("Measurement tolerance: "));
-    Serial.print(TOLERANCE_FOR_DECODERS_MARK_OR_SPACE_MATCHING);
+    Serial.print(TOLERANCE_FOR_DECODERS_MARK_OR_SPACE_MATCHING_PERCENT);
     Serial.println(F("%"));
 }
 

examples/IRremoteInfo/IRremoteInfo.ino

@@ -93,7 +93,7 @@ void setup() {
 }
 
 /*
- * Send Hob2Hood protocol
+ * Receive and send Hob2Hood protocol
  */
 void loop() {
     static long sLastMillisOfSend = 0;

examples/ReceiveAndSendHob2Hood/ReceiveAndSendHob2Hood.ino

@@ -199,9 +199,9 @@ void loop() {
         delay(DELAY_AFTER_SEND);
 
         /*
-         * Send 2 Panasonic 48 bit codes as generic Pulse Distance data, once with LSB and once with MSB first
+         * Send 2 Panasonic 48 bit codes as Pulse Distance data, once with LSB and once with MSB first
          */
-        Serial.println(F("Send Panasonic 0xB, 0x10 as generic 48 bit PulseDistance"));
+        Serial.println(F("Send Panasonic 0xB, 0x10 as 48 bit PulseDistance"));
         Serial.println(F(" LSB first"));
         Serial.flush();
 #if __INT_WIDTH__ < 32
@@ -226,7 +226,7 @@ void loop() {
 #endif
         delay(DELAY_AFTER_SEND);
 
-        Serial.println(F("Send generic 72 bit PulseDistance 0x5A AFEDCBA9 87654321 LSB first"));
+        Serial.println(F("Send 72 bit PulseDistance 0x5A AFEDCBA9 87654321 LSB first"));
         Serial.flush();
 #      if __INT_WIDTH__ < 32
         tRawData[0] = 0x87654321;  // LSB of tRawData[0] is sent first
@@ -240,7 +240,7 @@ void loop() {
 #      endif
         delay(DELAY_AFTER_SEND);
 
-        Serial.println(F("Send generic 52 bit PulseDistanceWidth 0xDCBA9 87654321 LSB first"));
+        Serial.println(F("Send 52 bit PulseDistanceWidth 0xDCBA9 87654321 LSB first"));
         Serial.flush();
         // Real PulseDistanceWidth (constant bit length) does not require a stop bit
 #if __INT_WIDTH__ < 32
@@ -252,7 +252,19 @@ void loop() {
 #endif
         delay(DELAY_AFTER_SEND);
 
-        Serial.println(F("Send generic 32 bit PulseWidth 0x87654321 LSB first"));
+        Serial.println(F("Send ASCII 7 bit PulseDistanceWidth LSB first"));
+        Serial.flush();
+        // Real PulseDistanceWidth (constant bit length) does theoretically not require a stop bit, but we know the stop bit from serial transmission
+        IrSender.sendPulseDistanceWidth(38, 6000, 500, 500, 1500, 1500, 500, sCommand, 7, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        delay(DELAY_AFTER_SEND);
+
+        Serial.println(F("Send Sony12 as PulseWidth LSB first"));
+        Serial.flush();
+        uint32_t tData = (uint32_t) sAddress << 7 | (sCommand & 0x7F);
+        IrSender.sendPulseDistanceWidth(38, 2400, 600, 1200, 600, 600, 600, tData, SIRCS_12_PROTOCOL, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        delay(DELAY_AFTER_SEND);
+
+        Serial.println(F("Send 32 bit PulseWidth 0x87654321 LSB first"));
         Serial.flush();
         // Real PulseDistanceWidth (constant bit length) does not require a stop bit
         IrSender.sendPulseDistanceWidth(38, 1000, 500, 600, 300, 300, 300, 0x87654321, 32, PROTOCOL_IS_LSB_FIRST, 0, 0);

examples/SendDemo/SendDemo.ino

@@ -3,8 +3,7 @@
  *
  * This example shows how to send a RAW signal using the IRremote library.
  * The example signal is actually a 32 bit NEC signal.
- * Remote Control button: LGTV Power On/Off.
- * Hex Value: 0x20DF10EF, 32 bits
+ * Protocol=NEC Address=0x4 Command=0x18 Raw-Data=0xE718FB04 32 bits LSB first
  *
  * If it is a supported protocol, it is more efficient to use the protocol send function
  * (here sendNEC) to send the signal.
@@ -14,7 +13,7 @@
  ************************************************************************************
  * MIT License
  *
- * Copyright (c) 2020-2022 Armin Joachimsmeyer
+ * Copyright (c) 2020-2024 Armin Joachimsmeyer
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
@@ -68,59 +67,62 @@ void setup() {
 }
 
 /*
- * NEC address=0xFB0C, command=0x18
+ * NEC address=0x04 (0xFB04), command=0x18 (0xE718)
  *
- * This is data in byte format.
+ * This is the raw data array in byte format.
  * The uint8_t/byte elements contain the number of ticks in 50 us.
  * The uint16_t format contains the (number of ticks * 50) if generated by IRremote,
  * so the uint16_t format has exact the same resolution but requires double space.
  * With the uint16_t format, you are able to modify the timings to meet the standards,
  * e.g. use 560 (instead of 11 * 50) for NEC or use 432 for Panasonic. But in this cases,
  * you better use the timing generation functions e.g. sendNEC() directly.
  */
-const uint8_t rawDataP[]
-#if defined(__AVR__)
-PROGMEM
-#endif
-= { 180, 90 /*Start bit*/, 11, 11, 11, 11, 11, 34, 11, 34/*0011 0xC of 16 bit address LSB first*/, 11, 11, 11, 11, 11, 11, 11,
+const uint8_t rawDataP[] PROGMEM
+= { 180, 90 /*Start bit*/, 11, 11, 11, 11, 11, 34, 11, 11/*0010 0x4 of 8 bit address LSB first*/, 11, 11, 11, 11, 11, 11, 11,
         11/*0000*/, 11, 34, 11, 34, 11, 11, 11, 34/*1101 0xB*/, 11, 34, 11, 34, 11, 34, 11, 34/*1111*/, 11, 11, 11, 11, 11, 11, 11,
         34/*0001 0x08 of command LSB first*/, 11, 34, 11, 11, 11, 11, 11, 11/*1000 0x01*/, 11, 34, 11, 34, 11, 34, 11,
         11/*1110 Inverted 8 of command*/, 11, 11, 11, 34, 11, 34, 11, 34/*0111 inverted 1 of command*/, 11 /*stop bit*/};
 
+/*
+ * The same frame as above. Values are NOT multiple of 50, but are taken from the NEC timing definitions
+ */
+const uint16_t rawData[] = { 9000, 4500/*Start bit*/, 560, 560, 560, 560, 560, 1690, 560,
+        560/*0010 0x4 of 8 bit address LSB first*/, 560, 560, 560, 560, 560, 560, 560, 560/*0000*/, 560, 1690, 560, 1690, 560, 560,
+        560, 1690/*1101 0xB - inverted 0x04*/, 560, 1690, 560, 1690, 560, 1690, 560, 1690/*1111 - inverted 0*/, 560, 560, 560, 560,
+        560, 560, 560, 1690/*0001 0x08 of command LSB first*/, 560, 1690, 560, 560, 560, 560, 560, 560/*1000 0x01*/, 560, 1690, 560,
+        1690, 560, 1690, 560, 560/*1110 Inverted 8 of command*/, 560, 560, 560, 1690, 560, 1690, 560,
+        1690/*1111 inverted 0 of command*/, 560 /*stop bit*/}; // Using exact NEC timing
+
 void loop() {
 
-#if !(defined(__AVR_ATtiny25__) || defined(__AVR_ATtiny45__) || defined(__AVR_ATtiny85__))
+#if FLASHEND > 0x1FFF // For more than 8k flash => not for ATtiny85 etc.
     /*
      * Send hand crafted data from RAM
-     * The values are NOT multiple of 50, but are taken from the NEC timing definitions
      */
-    Serial.println(F("Send NEC 16 bit address=0xFB04 and command 0x08 with exact timing (16 bit array format)"));
+    Serial.println(F("Send NEC 8 bit address=0x04 (0xFB04) and command 0x18 (0xE718) with exact timing (16 bit array format)"));
     Serial.flush();
-
-    const uint16_t rawData[] = { 9000, 4500/*Start bit*/, 560, 560, 560, 560, 560, 1690, 560,
-            560/*0010 0x4 of 16 bit address LSB first*/, 560, 560, 560, 560, 560, 560, 560, 560/*0000*/, 560, 1690, 560, 1690, 560,
-            560, 560, 1690/*1101 0xB*/, 560, 1690, 560, 1690, 560, 1690, 560, 1690/*1111*/, 560, 560, 560, 560, 560, 560, 560,
-            1690/*0001 0x08 of command LSB first*/, 560, 560, 560, 560, 560, 560, 560, 560/*0000 0x00*/, 560, 1690, 560, 1690, 560,
-            1690, 560, 560/*1110 Inverted 8 of command*/, 560, 1690, 560, 1690, 560, 1690, 560, 1690/*1111 inverted 0 of command*/,
-            560 /*stop bit*/}; // Using exact NEC timing
     IrSender.sendRaw(rawData, sizeof(rawData) / sizeof(rawData[0]), NEC_KHZ); // Note the approach used to automatically calculate the size of the array.
 
-    delay(1000); // delay must be greater than 5 ms (RECORD_GAP_MICROS), otherwise the receiver sees it as one long signal
+    delay(1000); // delay must be greater than 8 ms (RECORD_GAP_MICROS), otherwise the receiver sees it as one long signal
+
 #endif
 
     /*
      * Send byte data direct from FLASH
      * Note the approach used to automatically calculate the size of the array.
      */
-    Serial.println(F("Send NEC 16 bit address 0xFB0C and data 0x18 with (50 us) tick resolution timing (8 bit array format) "));
+    Serial.println(F("Send NEC 8 bit address 0x04 and command 0x18 with (50 us) tick resolution timing (8 bit array format) "));
     Serial.flush();
     IrSender.sendRaw_P(rawDataP, sizeof(rawDataP) / sizeof(rawDataP[0]), NEC_KHZ);
 
-    delay(1000); // delay must be greater than 5 ms (RECORD_GAP_MICROS), otherwise the receiver sees it as one long signal
+    delay(1000); // delay must be greater than 8 ms (RECORD_GAP_MICROS), otherwise the receiver sees it as one long signal
 
-    Serial.println(F("Send NEC 16 bit address 0x0102, 8 bit data 0x34 with generated timing"));
+    /*
+     * Send the same frame using NEC encoder
+     */
+    Serial.println(F("Send NEC 16 bit address 0x04, 8 bit command 0x18 with NEC encoder"));
     Serial.flush();
-    IrSender.sendNEC(0x0102, 0x34, 0);
+    IrSender.sendNEC(0x04, 0x18, 0);
 
     delay(3000);
 }

examples/SendRawDemo/SendRawDemo.ino

@@ -469,10 +469,10 @@ void loop() {
 #  endif
 
 #  if defined(DECODE_PANASONIC) || defined(DECODE_KASEIKYO)
-        Serial.println(F("Send Panasonic 0xB, 0x10 as 48 bit generic PulseDistance using ProtocolConstants"));
+        Serial.println(F("Send Panasonic 0xB, 0x10 as 48 bit PulseDistance using ProtocolConstants"));
         Serial.flush();
 #    if __INT_WIDTH__ < 32
-        IRRawDataType tRawData[] = { 0xB02002, 0xA010, 0x0 }; // LSB of tRawData[0] is sent first
+        IRRawDataType tRawData[4] = { 0xB02002, 0xA010, 0x0, 0x0 }; // LSB of tRawData[0] is sent first
         IrSender.sendPulseDistanceWidthFromArray(&KaseikyoProtocolConstants, &tRawData[0], 48, NO_REPEATS); // Panasonic is a Kaseikyo variant
         checkReceive(0x0B, 0x10);
 #    else
@@ -482,9 +482,9 @@ void loop() {
         delay(DELAY_AFTER_SEND);
 
         /*
-         * Send 2 Panasonic 48 bit codes as generic Pulse Distance data, once with LSB and once with MSB first
+         * Send 2 Panasonic 48 bit codes as Pulse Distance data, once with LSB and once with MSB first
          */
-        Serial.println(F("Send Panasonic 0xB, 0x10 as generic 48 bit PulseDistance"));
+        Serial.println(F("Send Panasonic 0xB, 0x10 as 48 bit PulseDistance"));
         Serial.println(F("-LSB first"));
         Serial.flush();
 #    if __INT_WIDTH__ < 32
@@ -516,7 +516,7 @@ void loop() {
 
 #  if defined(DECODE_DISTANCE_WIDTH)
 #    if defined(USE_MSB_DECODING_FOR_DISTANCE_DECODER)
-        Serial.println(F("Send generic 52 bit PulseDistance 0x43D8613C and 0x3BC3B MSB first"));
+        Serial.println(F("Send 52 bit PulseDistance 0x43D8613C and 0x3BC3B MSB first"));
         Serial.flush();
 #      if __INT_WIDTH__ < 32
         tRawData[0] = 0x43D8613C;  // MSB of tRawData[0] is sent first
@@ -530,7 +530,7 @@ void loop() {
 #      endif
         delay(DELAY_AFTER_SEND);
 
-        Serial.println(F("Send generic 52 bit PulseDistanceWidth 0x43D8613C and 0x3BC3B MSB first"));
+        Serial.println(F("Send 52 bit PulseDistanceWidth 0x43D8613C and 0x3BC3B MSB first"));
         Serial.flush();
         // Real PulseDistanceWidth (constant bit length) does not require a stop bit
 #      if __INT_WIDTH__ < 32
@@ -541,15 +541,15 @@ void loop() {
         checkReceivedRawData(0x123456789ABC);
 #      endif
         delay(DELAY_AFTER_SEND);
-        Serial.println(F("Send generic 32 bit PulseWidth 0x43D8613C MSB first"));
+        Serial.println(F("Send 32 bit PulseWidth 0x43D8613C MSB first"));
         Serial.flush();
         // Real PulseDistanceWidth (constant bit length) does not require a stop bit
         IrSender.sendPulseDistanceWidth(38, 1000, 500, 600, 300, 300, 300, 0x43D8613C, 32, PROTOCOL_IS_MSB_FIRST, 0, 0);
         checkReceivedRawData(0x43D8613C);
         delay(DELAY_AFTER_SEND);
 
 #    else // defined(USE_MSB_DECODING_FOR_DISTANCE_DECODER)
-        Serial.println(F("Send generic 72 bit PulseDistance 0x5A AFEDCBA9 87654321 LSB first"));
+        Serial.println(F("Send 72 bit PulseDistance 0x5A AFEDCBA9 87654321 LSB first"));
         Serial.flush();
 #      if __INT_WIDTH__ < 32
         tRawData[0] = 0x87654321;  // LSB of tRawData[0] is sent first
@@ -565,35 +565,63 @@ void loop() {
 #      endif
         delay(DELAY_AFTER_SEND);
 
-        Serial.println(F("Send generic 52 bit PulseDistanceWidth 0xDCBA9 87654321 LSB first"));
+        Serial.println(F("Send 52 bit PulseDistanceWidth 0xDCBA9 87654321 LSB first"));
         Serial.flush();
-        // Real PulseDistanceWidth (constant bit length) does not require a stop bit
+        // Real PulseDistanceWidth (constant bit length) does theoretically not require a stop bit, but we know the stop bit from serial transmission
 #      if __INT_WIDTH__ < 32
         tRawData[1] = 0xDCBA9;
-        IrSender.sendPulseDistanceWidthFromArray(38, 300, 600, 600, 300, 300, 600, &tRawData[0], 52, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        IrSender.sendPulseDistanceWidthFromArray(38, 300, 600, 300, 600, 600, 300, &tRawData[0], 52, PROTOCOL_IS_LSB_FIRST, 0, 0);
         checkReceivedArray(tRawData, 2);
 #      else
-        IrSender.sendPulseDistanceWidth(38, 300, 600, 600, 300, 300, 600, 0xDCBA987654321, 52, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        IrSender.sendPulseDistanceWidth(38, 300, 600, 300, 600, 600, 300, 0xDCBA987654321, 52, PROTOCOL_IS_LSB_FIRST, 0, 0);
         checkReceivedRawData(0xDCBA987654321);
 #      endif
         delay(DELAY_AFTER_SEND);
 
-        Serial.println(F("Send generic 32 bit PulseWidth 0x87654321 LSB first"));
+        Serial.println(F("Send 52 bit PulseDistanceWidth 0xDCBA9 87654321 LSB first with inverse timing and data"));
+        Serial.flush();
+#      if __INT_WIDTH__ < 32
+        tRawData[2] = ~tRawData[0];
+        tRawData[3] = ~tRawData[1];
+        IrSender.sendPulseDistanceWidthFromArray(38, 300, 600, 600, 300, 300, 600, &tRawData[2], 52, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        checkReceivedArray(tRawData, 2);
+#      else
+        IrSender.sendPulseDistanceWidth(38, 300, 600, 600, 300, 300, 600, ~0xDCBA987654321, 52, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        checkReceivedRawData(0xDCBA987654321);
+#      endif
+        delay(DELAY_AFTER_SEND);
+
+        Serial.println(F("Send ASCII 7 bit PulseDistanceWidth LSB first"));
+        Serial.flush();
+        // Real PulseDistanceWidth (constant bit length) does theoretically not require a stop bit, but we know the stop bit from serial transmission
+        IrSender.sendPulseDistanceWidth(38, 6000, 500, 500, 1500, 1500, 500, sCommand, 7, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        checkReceivedRawData(sCommand);
+        delay(DELAY_AFTER_SEND);
+
+        Serial.println(F("Send Sony12 as PulseWidth LSB first"));
+        Serial.flush();
+        uint32_t tData = (uint32_t) sAddress << 7 | (sCommand & 0x7F);
+        IrSender.sendPulseDistanceWidth(38, 2400, 600, 1200, 600, 600, 600, tData, SIRCS_12_PROTOCOL, PROTOCOL_IS_LSB_FIRST, 0, 0);
+        checkReceive(sAddress & 0x1F, sCommand & 0x7F);
+        delay(DELAY_AFTER_SEND);
+
+        Serial.println(F("Send 32 bit PulseWidth 0x87654321 LSB first"));
         Serial.flush();
-        // Real PulseDistanceWidth (constant bit length) does not require a stop bit
         IrSender.sendPulseDistanceWidth(38, 1000, 500, 600, 300, 300, 300, 0x87654321, 32, PROTOCOL_IS_LSB_FIRST, 0, 0);
         checkReceivedRawData(0x87654321);
         delay(DELAY_AFTER_SEND);
+
 #    endif // defined(USE_MSB_DECODING_FOR_DISTANCE_DECODER)
 #  endif // defined(DECODE_DISTANCE_WIDTH)
 
 #  if defined(DECODE_MAGIQUEST)
-        Serial.println(F("Send MagiQuest 0x6BCDFF00, 0x176 as generic 55 bit PulseDistanceWidth MSB first"));
+        Serial.println(F("Send MagiQuest 0x6BCDFF00, 0x176 as 55 bit PulseDistanceWidth MSB first"));
         Serial.flush();
 #    if __INT_WIDTH__ < 32
         tRawData[0] = 0x01AF37FC; // We have 1 header (start) bit and 7 start bits and 31 address bits for MagiQuest, so 0x6BCDFF00 is shifted 2 left
-        tRawData[1] = 0x017619; // We send only 23 instead of 24 bite here! 19 is the checksum
-        IrSender.sendPulseDistanceWidthFromArray(38, 287, 864, 576, 576, 287, 864, &tRawData[0], 55, PROTOCOL_IS_MSB_FIRST, 0, 0);
+        tRawData[1] = 0x017619; // We send only 23 bits here! 0x19 is the checksum
+        IrSender.sendPulseDistanceWidthFromArray(38, 287, 864, 576, 576, 287, 864, &tRawData[0], 55,
+        PROTOCOL_IS_MSB_FIRST | SUPPRESS_STOP_BIT, 0, 0);
 #    else
         // 0xD79BFE00 is 0x6BCDFF00 is shifted 1 left
         IrSender.sendPulseDistanceWidth(38, 287, 864, 576, 576, 287, 864, 0xD79BFE017619, 55, PROTOCOL_IS_MSB_FIRST, 0, 0);
@@ -664,7 +692,7 @@ void loop() {
 #if defined(DECODE_SONY)
     Serial.println(F("Send Sony/SIRCS with 7 command and 5 address bits"));
     Serial.flush();
-    IrSender.sendSony(sAddress & 0x1F, sCommand, 0);
+    IrSender.sendSony(sAddress & 0x1F, sCommand, 0); // SIRCS_12_PROTOCOL is default
     checkReceive(sAddress & 0x1F, sCommand & 0x7F);
     delay(DELAY_AFTER_SEND);