Skip to content

Commit 5132081

Browse files
committed
AS gem doesn't depend on nokogiri so shows a nicer error if users haven't installed
1 parent 95e9ced commit 5132081

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

activesupport/lib/active_support/xml_mini/nokogiri.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
require 'nokogiri'
1+
begin
2+
require 'nokogiri'
3+
rescue LoadError => e
4+
$stderr.puts "You don't have nokogiri installed in your application. Please add it to your Gemfile and run bundle install"
5+
raise e
6+
end
27
require 'active_support/core_ext/object/blank'
38

49
# = XmlMini Nokogiri implementation

activesupport/lib/active_support/xml_mini/nokogirisax.rb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
require 'nokogiri'
1+
begin
2+
require 'nokogiri'
3+
rescue LoadError => e
4+
$stderr.puts "You don't have nokogiri installed in your application. Please add it to your Gemfile and run bundle install"
5+
raise e
6+
end
27
require 'active_support/core_ext/object/blank'
38

49
# = XmlMini Nokogiri implementation using a SAX-based parser
@@ -80,4 +85,4 @@ def parse(data)
8085
end
8186
end
8287
end
83-
end
88+
end

0 commit comments

Comments
 (0)