Skip to content

Commit 1568e19

Browse files
committed
Remove GSON dependencies from blank-java, java-basic examples
- This commit removes GSON dependencies from blank-java and java-basic examples. - Removed logging the context as this isn't a common operation. - Refactored the java-basic Stream example, and manually tested with an input string. - Tested and verified that all samples still work.
1 parent 0cf1ca7 commit 1568e19

File tree

13 files changed

+30
-88
lines changed

13 files changed

+30
-88
lines changed

sample-apps/blank-java/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ dependencies {
1616
implementation 'com.amazonaws:aws-xray-recorder-sdk-aws-sdk-v2-instrumentor'
1717
implementation 'com.amazonaws:aws-lambda-java-core:1.2.1'
1818
implementation 'com.amazonaws:aws-lambda-java-events:2.2.9'
19-
implementation 'com.fasterxml.jackson.core:jackson-databind:[2.14.0,)'
2019
implementation 'org.apache.logging.log4j:log4j-api:[2.17.1,)'
2120
implementation 'org.apache.logging.log4j:log4j-core:[2.17.1,)'
2221
runtimeOnly 'org.apache.logging.log4j:log4j-slf4j18-impl:[2.17.1,)'

sample-apps/blank-java/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@
2727
<artifactId>aws-lambda-java-log4j2</artifactId>
2828
<version>1.5.0</version>
2929
</dependency>
30-
<dependency>
31-
<groupId>com.fasterxml.jackson.core</groupId>
32-
<artifactId>jackson-databind</artifactId>
33-
<version>[2.14.0,)</version>
34-
</dependency>
3530
<dependency>
3631
<groupId>org.apache.logging.log4j</groupId>
3732
<artifactId>log4j-api</artifactId>

sample-apps/blank-java/src/main/java/example/Handler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ public String handleRequest(Map<String,String> event, Context context) {
2828
// log execution details
2929
logger.info("ENVIRONMENT VARIABLES: " + System.getenv());
3030
logger.info("EVENT: " + event);
31-
logger.info("CONTEXT: " + context);
3231

3332
// process event
3433
GetAccountSettingsResponse response;

sample-apps/java-basic/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ repositories {
88

99
dependencies {
1010
implementation 'com.amazonaws:aws-lambda-java-core:1.2.1'
11-
implementation 'com.google.code.gson:gson:2.8.6'
1211
testImplementation 'org.apache.logging.log4j:log4j-api:[2.17.1,)'
1312
testImplementation 'org.apache.logging.log4j:log4j-core:[2.17.1,)'
1413
testImplementation 'org.apache.logging.log4j:log4j-slf4j18-impl:[2.17.1,)'

sample-apps/java-basic/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
<artifactId>aws-lambda-java-core</artifactId>
1818
<version>1.2.1</version>
1919
</dependency>
20-
<dependency>
21-
<groupId>com.google.code.gson</groupId>
22-
<artifactId>gson</artifactId>
23-
<version>2.8.6</version>
24-
</dependency>
2520
<dependency>
2621
<groupId>org.apache.logging.log4j</groupId>
2722
<artifactId>log4j-api</artifactId>

sample-apps/java-basic/src/main/java/example/Handler.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,21 @@
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
55
import com.amazonaws.services.lambda.runtime.LambdaLogger;
66

7-
import com.google.gson.Gson;
8-
import com.google.gson.GsonBuilder;
9-
107
import java.util.Map;
118

129
// Handler value: example.Handler
1310
public class Handler implements RequestHandler<Map<String,String>, String>{
14-
Gson gson = new GsonBuilder().setPrettyPrinting().create();
11+
1512
@Override
1613
public String handleRequest(Map<String,String> event, Context context)
1714
{
1815
LambdaLogger logger = context.getLogger();
1916
String response = "200 OK";
2017
// log execution details
21-
logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));
22-
logger.log("CONTEXT: " + gson.toJson(context));
18+
logger.log("ENVIRONMENT VARIABLES: " + System.getenv());
19+
2320
// process event
24-
logger.log("EVENT: " + gson.toJson(event));
21+
logger.log("EVENT: " + event);
2522
logger.log("EVENT TYPE: " + event.getClass());
2623
return response;
2724
}

sample-apps/java-basic/src/main/java/example/HandlerDivide.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,11 @@
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
55
import com.amazonaws.services.lambda.runtime.LambdaLogger;
66

7-
import com.google.gson.Gson;
8-
import com.google.gson.GsonBuilder;
9-
107
import java.util.List;
118

129
// Handler value: example.HandlerDivide
1310
public class HandlerDivide implements RequestHandler<List<Integer>, Integer>{
14-
Gson gson = new GsonBuilder().setPrettyPrinting().create();
11+
1512
@Override
1613
public Integer handleRequest(List<Integer> event, Context context)
1714
{
@@ -23,7 +20,7 @@ public Integer handleRequest(List<Integer> event, Context context)
2320
}
2421
int numerator = event.get(0);
2522
int denominator = event.get(1);
26-
logger.log("EVENT: " + gson.toJson(event));
23+
logger.log("EVENT: " + event);
2724
logger.log("EVENT TYPE: " + event.getClass().toString());
2825
return numerator/denominator;
2926
}

sample-apps/java-basic/src/main/java/example/HandlerInteger.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,15 @@
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
55
import com.amazonaws.services.lambda.runtime.LambdaLogger;
66

7-
import com.google.gson.Gson;
8-
import com.google.gson.GsonBuilder;
9-
107
// Handler value: example.HandlerInteger
118
public class HandlerInteger implements RequestHandler<Integer, Integer>{
12-
Gson gson = new GsonBuilder().setPrettyPrinting().create();
9+
1310
@Override
1411
public Integer handleRequest(Integer event, Context context)
1512
{
1613
LambdaLogger logger = context.getLogger();
1714
// process event
18-
logger.log("EVENT: " + gson.toJson(event));
15+
logger.log("EVENT: " + event);
1916
logger.log("EVENT TYPE: " + event.getClass().toString());
2017
// return amount of time remaining before timeout
2118
return context.getRemainingTimeInMillis();

sample-apps/java-basic/src/main/java/example/HandlerList.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,17 @@
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
55
import com.amazonaws.services.lambda.runtime.LambdaLogger;
66

7-
import com.google.gson.Gson;
8-
import com.google.gson.GsonBuilder;
9-
107
import java.util.List;
118

129
// Handler value: example.HandlerList
1310
public class HandlerList implements RequestHandler<List<Integer>, Integer>{
14-
Gson gson = new GsonBuilder().setPrettyPrinting().create();
11+
1512
@Override
1613
public Integer handleRequest(List<Integer> event, Context context)
1714
{
1815
LambdaLogger logger = context.getLogger();
1916
// process event
20-
logger.log("EVENT: " + gson.toJson(event));
17+
logger.log("EVENT: " + event);
2118
logger.log("EVENT TYPE: " + event.getClass().toString());
2219
return context.getRemainingTimeInMillis() ;
2320
}
Lines changed: 12 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,30 @@
11
package example;
22

33
import com.amazonaws.services.lambda.runtime.Context;
4-
import com.amazonaws.services.lambda.runtime.LambdaLogger;
54
import com.amazonaws.services.lambda.runtime.RequestStreamHandler;
65

7-
import com.google.gson.Gson;
8-
import com.google.gson.GsonBuilder;
9-
import com.google.gson.JsonSyntaxException;
10-
11-
import java.util.HashMap;
126
import java.io.InputStream;
137
import java.io.IOException;
148
import java.io.OutputStream;
15-
import java.io.InputStreamReader;
16-
import java.io.BufferedReader;
17-
import java.io.OutputStreamWriter;
18-
import java.io.PrintWriter;
19-
import java.io.BufferedWriter;
20-
import java.nio.charset.Charset;
21-
import java.lang.IllegalStateException;
229

2310
// Handler value: example.HandlerStream
2411
public class HandlerStream implements RequestStreamHandler {
25-
Gson gson = new GsonBuilder().setPrettyPrinting().create();
12+
2613
@Override
2714
public void handleRequest(InputStream inputStream, OutputStream outputStream, Context context) throws IOException
2815
{
29-
LambdaLogger logger = context.getLogger();
30-
BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream, Charset.forName("US-ASCII")));
31-
PrintWriter writer = new PrintWriter(new BufferedWriter(new OutputStreamWriter(outputStream, Charset.forName("US-ASCII"))));
32-
try
33-
{
34-
HashMap event = gson.fromJson(reader, HashMap.class);
35-
logger.log("STREAM TYPE: " + inputStream.getClass().toString());
36-
logger.log("EVENT TYPE: " + event.getClass().toString());
37-
writer.write(gson.toJson(event));
38-
if (writer.checkError())
39-
{
40-
logger.log("WARNING: Writer encountered an error.");
16+
int nextChar;
17+
try {
18+
while ((nextChar = inputStream.read()) != -1) {
19+
outputStream.write(nextChar);
4120
}
42-
}
43-
catch (IllegalStateException | JsonSyntaxException exception)
44-
{
45-
logger.log(exception.toString());
46-
}
47-
finally
48-
{
49-
reader.close();
50-
writer.close();
21+
} catch (IOException e) {
22+
e.printStackTrace();
23+
} finally {
24+
inputStream.close();
25+
String finalString = outputStream.toString();
26+
System.out.println(finalString);
27+
outputStream.close();
5128
}
5229
}
5330
}

sample-apps/java-basic/src/main/java/example/HandlerString.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,16 @@
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
55
import com.amazonaws.services.lambda.runtime.LambdaLogger;
66

7-
import com.google.gson.Gson;
8-
import com.google.gson.GsonBuilder;
9-
107
// Handler value: example.HandlerString
118
public class HandlerString implements RequestHandler<String, Integer>{
12-
Gson gson = new GsonBuilder().setPrettyPrinting().create();
9+
1310
@Override
1411
public Integer handleRequest(String event, Context context)
1512
{
1613
LambdaLogger logger = context.getLogger();
1714
// process event
18-
logger.log("EVENT: " + gson.toJson(event));
15+
logger.log("EVENT: " + event);
1916
logger.log("EVENT TYPE: " + event.getClass().toString());
20-
return context.getRemainingTimeInMillis() ;
17+
return context.getRemainingTimeInMillis();
2118
}
2219
}

sample-apps/java-basic/src/main/java/example/HandlerWeatherData.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,18 @@
44
import com.amazonaws.services.lambda.runtime.RequestHandler;
55
import com.amazonaws.services.lambda.runtime.LambdaLogger;
66

7-
import com.google.gson.Gson;
8-
import com.google.gson.GsonBuilder;
9-
10-
import java.util.Map;
11-
127
// Handler value: example.HandlerWeatherData
138
public class HandlerWeatherData implements RequestHandler<WeatherData, WeatherData>{
14-
Gson gson = new GsonBuilder().setPrettyPrinting().create();
9+
1510
@Override
1611
public WeatherData handleRequest(WeatherData event, Context context)
1712
{
1813
LambdaLogger logger = context.getLogger();
19-
// process event
20-
logger.log("EVENT: " + gson.toJson(event));
14+
// log execution details
15+
logger.log("EVENT: " + event);
2116
logger.log("EVENT TYPE: " + event.getClass().toString());
17+
18+
// // process event
2219
return event;
2320
}
2421
}

sample-apps/java-basic/src/test/java/example/InvokeTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
11
package example;
22

3-
import static org.junit.jupiter.api.Assertions.assertEquals;
43
import static org.junit.jupiter.api.Assertions.assertTrue;
54
import org.junit.jupiter.api.Test;
65

76
import com.amazonaws.services.lambda.runtime.Context;
8-
import com.amazonaws.services.lambda.runtime.RequestHandler;
97

108
import org.slf4j.Logger;
119
import org.slf4j.LoggerFactory;
1210

13-
import java.util.List;
14-
import java.util.ArrayList;
1511
import java.util.HashMap;
1612

1713
class InvokeTest {

0 commit comments

Comments
 (0)