Updated sample codes and also the ones on docs to follow the best practice for using Java String

predatorray · web-flow · commit 4e50ed4f935c · 2023-05-19T09:53:39.000-07:00
diff --git a/doc_source/java-context.md b/doc_source/java-context.md
@@ -33,7 +33,7 @@ public class Handler implements RequestHandler<Map<String,String>, String>{
   public String handleRequest(Map<String,String> event, Context context)
   {
     LambdaLogger logger = context.getLogger();
-    String response = new String("200 OK");
+    String response = "200 OK";
     // log execution details
     logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));
     logger.log("CONTEXT: " + gson.toJson(context));
@@ -79,10 +79,10 @@ import [com\.amazonaws\.services\.lambda\.runtime\.LambdaLogger](https://github.
 public class TestContext implements Context{
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   ...
   public LambdaLogger getLogger(){
diff --git a/doc_source/java-handler.md b/doc_source/java-handler.md
@@ -20,7 +20,7 @@ public class Handler implements RequestHandler<Map<String,String>, String>{
   public String handleRequest(Map<String,String> event, Context context)
   {
     LambdaLogger logger = context.getLogger();
-    String response = new String("200 OK");
+    String response = "200 OK";
     // log execution details
     logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));
     logger.log("CONTEXT: " + gson.toJson(context));
diff --git a/doc_source/java-logging.md b/doc_source/java-logging.md
@@ -29,7 +29,7 @@ public class Handler implements RequestHandler<Object, String>{
   public String handleRequest(Object event, Context context)
   {
     LambdaLogger logger = context.getLogger();
-    String response = new String("SUCCESS");
+    String response = "SUCCESS";
     // log execution details
     logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));
     logger.log("CONTEXT: " + gson.toJson(context));
diff --git a/sample-apps/blank-java/src/test/java/example/TestContext.java b/sample-apps/blank-java/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/java-basic/src/test/java/example/TestContext.java b/sample-apps/java-basic/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/java-events-v1sdk/src/main/java/example/Handler.java b/sample-apps/java-events-v1sdk/src/main/java/example/Handler.java
@@ -19,7 +19,7 @@ public class Handler implements RequestHandler<S3Event, String>{
   @Override
   public String handleRequest(S3Event event, Context context)
   {
-    String response = new String("200 OK");
+    String response = "200 OK";
     S3EventNotificationRecord record = event.getRecords().get(0);
     String srcBucket = record.getS3().getBucket().getName();
     // Object key may have spaces or unicode non-ASCII characters.
diff --git a/sample-apps/java-events-v1sdk/src/main/java/example/HandlerDynamoDB.java b/sample-apps/java-events-v1sdk/src/main/java/example/HandlerDynamoDB.java
@@ -18,7 +18,7 @@ public class HandlerDynamoDB implements RequestHandler<DynamodbEvent, String>{
   @Override
   public String handleRequest(DynamodbEvent event, Context context)
   {
-    String response = new String("200 OK");
+    String response = "200 OK";
     for (DynamodbStreamRecord record : event.getRecords()){
       logger.info(record.getEventID());
       logger.info(record.getEventName());
diff --git a/sample-apps/java-events-v1sdk/src/main/java/example/HandlerKinesis.java b/sample-apps/java-events-v1sdk/src/main/java/example/HandlerKinesis.java
@@ -18,7 +18,7 @@ public class HandlerKinesis implements RequestHandler<KinesisEvent, String>{
   @Override
   public String handleRequest(KinesisEvent event, Context context)
   {
-    String response = new String("200 OK");
+    String response = "200 OK";
     for(KinesisEventRecord record : event.getRecords()) {
       logger.info(gson.toJson(record.getKinesis().getData()));
     }
diff --git a/sample-apps/java-events-v1sdk/src/test/java/example/TestContext.java b/sample-apps/java-events-v1sdk/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/java-events/src/test/java/example/TestContext.java b/sample-apps/java-events/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;
diff --git a/sample-apps/s3-java/src/test/java/example/TestContext.java b/sample-apps/s3-java/src/test/java/example/TestContext.java
@@ -9,22 +9,22 @@ public class TestContext implements Context{
 
   public TestContext() {}
   public String getAwsRequestId(){
-    return new String("495b12a8-xmpl-4eca-8168-160484189f99");
+    return "495b12a8-xmpl-4eca-8168-160484189f99";
   }
   public String getLogGroupName(){
-    return new String("/aws/lambda/my-function");
+    return "/aws/lambda/my-function";
   }
   public String getLogStreamName(){
-    return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");
+    return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";
   }
   public String getFunctionName(){
-    return new String("my-function");
+    return "my-function";
   }
   public String getFunctionVersion(){
-    return new String("$LATEST");
+    return "$LATEST";
   }
   public String getInvokedFunctionArn(){
-    return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");
+    return "arn:aws:lambda:us-east-2:123456789012:function:my-function";
   }
   public CognitoIdentity getIdentity(){
     return null;

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public class Handler implements RequestHandler<Map<String,String>, String>{`
`20`	`20`	`public String handleRequest(Map<String,String> event, Context context)`
`21`	`21`	`{`
`22`	`22`	`LambdaLogger logger = context.getLogger();`
`23`		`- String response = new String("200 OK");`
	`23`	`+ String response = "200 OK";`
`24`	`24`	`// log execution details`
`25`	`25`	`logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));`
`26`	`26`	`logger.log("CONTEXT: " + gson.toJson(context));`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public class Handler implements RequestHandler<Object, String>{`
`29`	`29`	`public String handleRequest(Object event, Context context)`
`30`	`30`	`{`
`31`	`31`	`LambdaLogger logger = context.getLogger();`
`32`		`- String response = new String("SUCCESS");`
	`32`	`+ String response = "SUCCESS";`
`33`	`33`	`// log execution details`
`34`	`34`	`logger.log("ENVIRONMENT VARIABLES: " + gson.toJson(System.getenv()));`
`35`	`35`	`logger.log("CONTEXT: " + gson.toJson(context));`
Original file line number	Diff line number	Diff line change
`@@ -9,22 +9,22 @@ public class TestContext implements Context{`
`9`	`9`
`10`	`10`	`public TestContext() {}`
`11`	`11`	`public String getAwsRequestId(){`
`12`		`- return new String("495b12a8-xmpl-4eca-8168-160484189f99");`
	`12`	`+ return "495b12a8-xmpl-4eca-8168-160484189f99";`
`13`	`13`	`}`
`14`	`14`	`public String getLogGroupName(){`
`15`		`- return new String("/aws/lambda/my-function");`
	`15`	`+ return "/aws/lambda/my-function";`
`16`	`16`	`}`
`17`	`17`	`public String getLogStreamName(){`
`18`		`- return new String("2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a");`
	`18`	`+ return "2020/02/26/[$LATEST]704f8dxmpla04097b9134246b8438f1a";`
`19`	`19`	`}`
`20`	`20`	`public String getFunctionName(){`
`21`		`- return new String("my-function");`
	`21`	`+ return "my-function";`
`22`	`22`	`}`
`23`	`23`	`public String getFunctionVersion(){`
`24`		`- return new String("$LATEST");`
	`24`	`+ return "$LATEST";`
`25`	`25`	`}`
`26`	`26`	`public String getInvokedFunctionArn(){`
`27`		`- return new String("arn:aws:lambda:us-east-2:123456789012:function:my-function");`
	`27`	`+ return "arn:aws:lambda:us-east-2:123456789012:function:my-function";`
`28`	`28`	`}`
`29`	`29`	`public CognitoIdentity getIdentity(){`
`30`	`30`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public class Handler implements RequestHandler<S3Event, String>{`
`19`	`19`	`@Override`
`20`	`20`	`public String handleRequest(S3Event event, Context context)`
`21`	`21`	`{`
`22`		`- String response = new String("200 OK");`
	`22`	`+ String response = "200 OK";`
`23`	`23`	`S3EventNotificationRecord record = event.getRecords().get(0);`
`24`	`24`	`String srcBucket = record.getS3().getBucket().getName();`
`25`	`25`	`// Object key may have spaces or unicode non-ASCII characters.`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public class HandlerDynamoDB implements RequestHandler<DynamodbEvent, String>{`
`18`	`18`	`@Override`
`19`	`19`	`public String handleRequest(DynamodbEvent event, Context context)`
`20`	`20`	`{`
`21`		`- String response = new String("200 OK");`
	`21`	`+ String response = "200 OK";`
`22`	`22`	`for (DynamodbStreamRecord record : event.getRecords()){`
`23`	`23`	`logger.info(record.getEventID());`
`24`	`24`	`logger.info(record.getEventName());`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public class HandlerKinesis implements RequestHandler<KinesisEvent, String>{`
`18`	`18`	`@Override`
`19`	`19`	`public String handleRequest(KinesisEvent event, Context context)`
`20`	`20`	`{`
`21`		`- String response = new String("200 OK");`
	`21`	`+ String response = "200 OK";`
`22`	`22`	`for(KinesisEventRecord record : event.getRecords()) {`
`23`	`23`	`logger.info(gson.toJson(record.getKinesis().getData()));`
`24`	`24`	`}`