Skip to content

Commit 6161f7e

Browse files
committed
Update logging mechanism in blank-java
- Instead of SLF4J logger, use Context's logger (removes SLF4J dependency) - However, during unit testing, still requires SLF4J. Tests still show this logging option. - Verified that Maven/Gradle builds don't generate SLF4J warnings.
1 parent c8f10d2 commit 6161f7e

File tree

6 files changed

+21
-29
lines changed

6 files changed

+21
-29
lines changed

sample-apps/blank-java/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ repositories {
77
}
88

99
dependencies {
10-
implementation platform('software.amazon.awssdk:bom:2.10.73')
10+
implementation platform('software.amazon.awssdk:bom:2.10.72')
1111
implementation platform('com.amazonaws:aws-xray-recorder-sdk-bom:2.4.0')
1212
implementation 'software.amazon.awssdk:lambda'
1313
implementation 'com.amazonaws:aws-xray-recorder-sdk-core'
1414
implementation 'com.amazonaws:aws-lambda-java-core:1.2.1'
1515
implementation 'com.amazonaws:aws-lambda-java-events:2.2.9'
16-
runtimeOnly 'org.apache.logging.log4j:log4j-slf4j18-impl:[2.17.1,)'
16+
implementation 'org.slf4j:slf4j-nop:2.0.6'
1717
testImplementation 'com.amazonaws:aws-lambda-java-tests:1.1.1'
1818
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.2'
1919
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.8.2'

sample-apps/blank-java/pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
<version>2.2.9</version>
2424
</dependency>
2525
<dependency>
26-
<groupId>org.apache.logging.log4j</groupId>
27-
<artifactId>log4j-slf4j18-impl</artifactId>
28-
<version>[2.17.1,)</version>
29-
</dependency>
26+
<groupId>org.slf4j</groupId>
27+
<artifactId>slf4j-nop</artifactId>
28+
<version>2.0.6</version>
29+
</dependency>
3030
<dependency>
3131
<groupId>software.amazon.awssdk</groupId>
3232
<artifactId>lambda</artifactId>

sample-apps/blank-java/src/main/java/example/Handler.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,26 @@
11
package example;
22

33
import com.amazonaws.services.lambda.runtime.Context;
4+
import com.amazonaws.services.lambda.runtime.LambdaLogger;
45
import com.amazonaws.services.lambda.runtime.RequestHandler;
56

67
import java.util.Map;
78

8-
import org.slf4j.Logger;
9-
import org.slf4j.LoggerFactory;
10-
119
import software.amazon.awssdk.services.lambda.LambdaClient;
1210
import software.amazon.awssdk.services.lambda.model.GetAccountSettingsResponse;
1311
import software.amazon.awssdk.services.lambda.model.LambdaException;
1412

1513
// Handler value: example.Handler
1614
public class Handler implements RequestHandler<Map<String,String>, String> {
1715

18-
private static final Logger logger = LoggerFactory.getLogger(Handler.class);
1916
private static final LambdaClient lambdaClient = LambdaClient.builder().build();
2017

2118
@Override
2219
public String handleRequest(Map<String,String> event, Context context) {
2320

24-
logger.info("ENVIRONMENT VARIABLES: " + System.getenv());
25-
logger.info("EVENT: " + event);
21+
LambdaLogger logger = context.getLogger();
22+
logger.log("ENVIRONMENT VARIABLES: " + System.getenv());
23+
logger.log("EVENT: " + event);
2624

2725
GetAccountSettingsResponse response = null;
2826
try {

sample-apps/blank-java/src/main/resources/log4j2.xml

Lines changed: 0 additions & 16 deletions
This file was deleted.

sample-apps/blank-java/template-mvn.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,13 @@ Resources:
1818
- AWSXrayWriteOnlyAccess
1919
- AWSLambdaVPCAccessExecutionRole
2020
Tracing: Active
21+
Layers:
22+
- !Ref libs
23+
libs:
24+
Type: AWS::Serverless::LayerVersion
25+
Properties:
26+
LayerName: blank-java-lib
27+
Description: Dependencies for the blank-java sample app.
28+
ContentUri: build/blank-java-lib.zip
29+
CompatibleRuntimes:
30+
- java11

sample-apps/blank-java/template.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ Resources:
2727
Description: Dependencies for the blank-java sample app.
2828
ContentUri: build/blank-java-lib.zip
2929
CompatibleRuntimes:
30-
- java8
30+
- java11

0 commit comments

Comments
 (0)