Skip to content

Commit a3acd83

Browse files
committed
Merged PR 9300: fix uid tests
fix uid tests. this tests are failing on github, apparently they did not run on the builds in the internal repository. uid tests are related to the changes made for frontload
1 parent 2cea157 commit a3acd83

File tree

6 files changed

+12
-11
lines changed

6 files changed

+12
-11
lines changed

dist/powerbi-client.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! powerbi-client v2.6.2 | (c) 2016 Microsoft Corporation MIT */
1+
/*! powerbi-client v2.6.3 | (c) 2016 Microsoft Corporation MIT */
22
declare module "util" {
33
/**
44
* Raises a custom event with event data on the specified HTML element.

dist/powerbi.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "powerbi-client",
3-
"version": "2.6.2",
3+
"version": "2.6.3",
44
"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
55
"main": "dist/powerbi.js",
66
"typings": "dist/powerbi-client.d.ts",

src/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const config = {
2-
version: '2.6.2',
2+
version: '2.6.3',
33
type: 'js'
44
};
55

test/test.spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -251,12 +251,13 @@ describe('service', function () {
251251
formatLocale: 'formatName'
252252
}
253253
},
254-
groupId: "fakeGroupId"
254+
groupId: "fakeGroupId",
255+
uniqueId: "fakeUid",
255256
};
256257

257258
powerbi.embed($reportContainer[0], testConfiguration);
258259
var iframe = $reportContainer.find('iframe');
259-
expect(iframe.attr('src')).toEqual('fakeUrl?reportId=1&language=languageName&formatLocale=formatName');
260+
expect(iframe.attr('src')).toEqual('fakeUrl?reportId=1&language=languageName&formatLocale=formatName&uid=fakeUid');
260261
});
261262

262263
it('if attempting to embed without specifying an embed url, throw error', function () {
@@ -650,12 +651,12 @@ describe('service', function () {
650651
.appendTo('#powerbi-fixture');
651652

652653
// Act
653-
let report = powerbi.embed($reportContainer[0]);
654+
let report = powerbi.embed($reportContainer[0], { uniqueId: "fakeUid" });
654655

655656
// Assert
656657
var iframe = $reportContainer.find('iframe');
657658
expect(iframe.length).toEqual(1);
658-
expect(iframe.attr('src')).toEqual(embedUrl);
659+
expect(iframe.attr('src')).toEqual(embedUrl + "&uid=fakeUid");
659660
});
660661

661662
describe('findIdFromEmbedUrl', function () {

0 commit comments

Comments
 (0)