Skip to content

Commit e84f79f

Browse files
committed
Fixed django#18042 -- Advanced deprecation warnings.
Thanks Ramiro for the patch.
1 parent 227cec6 commit e84f79f

File tree

27 files changed

+75
-38
lines changed

27 files changed

+75
-38
lines changed

django/conf/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ def compat_patch_logging_config(logging_config):
181181
"handler: adding implicit debug-false-only filter. "
182182
"See http://docs.djangoproject.com/en/dev/releases/1.4/"
183183
"#request-exceptions-are-now-always-logged",
184-
PendingDeprecationWarning)
184+
DeprecationWarning)
185185

186186
filter_name = "require_debug_false"
187187

django/conf/urls/defaults.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import warnings
22
warnings.warn("django.conf.urls.defaults is deprecated; use django.conf.urls instead",
3-
PendingDeprecationWarning)
3+
DeprecationWarning)
44

55
from django.conf.urls import (handler403, handler404, handler500,
66
include, patterns, url)

django/contrib/admin/templatetags/adminmedia.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ def admin_media_prefix():
1111
"""
1212
warnings.warn(
1313
"The admin_media_prefix template tag is deprecated. "
14-
"Use the static template tag instead.", PendingDeprecationWarning)
14+
"Use the static template tag instead.", DeprecationWarning)
1515
return PrefixNode.handle_simple("ADMIN_MEDIA_PREFIX")

django/contrib/databrowse/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
from django.contrib.databrowse.sites import DatabrowsePlugin, ModelDatabrowse, DatabrowseSite, site
33

44

5-
warnings.warn("The Databrowse contrib app is deprecated",
6-
PendingDeprecationWarning)
5+
warnings.warn("The Databrowse contrib app is deprecated", DeprecationWarning)

django/contrib/formtools/tests/__init__.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from django.contrib.formtools import preview, utils
88
from django.contrib.formtools.wizard import FormWizard
99
from django.test import TestCase
10+
from django.test.utils import get_warnings_state, restore_warnings_state
1011
from django.test.utils import override_settings
1112
from django.utils import unittest
1213

@@ -40,12 +41,20 @@ class PreviewTests(TestCase):
4041

4142
def setUp(self):
4243
super(PreviewTests, self).setUp()
44+
self.save_warnings_state()
45+
warnings.filterwarnings('ignore', category=DeprecationWarning,
46+
module='django.contrib.formtools.wizard.legacy')
47+
4348
# Create a FormPreview instance to share between tests
4449
self.preview = preview.FormPreview(TestForm)
4550
input_template = '<input type="hidden" name="%s" value="%s" />'
4651
self.input = input_template % (self.preview.unused_name('stage'), "%d")
4752
self.test_data = {'field1':u'foo', 'field1_':u'asdf'}
4853

54+
def tearDown(self):
55+
super(PreviewTests, self).tearDown()
56+
self.restore_warnings_state()
57+
4958
def test_unused_name(self):
5059
"""
5160
Verifies name mangling to get uniue field name.

django/contrib/formtools/wizard/legacy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def __init__(self, form_list, initial=None):
3939
warnings.warn(
4040
'Old-style form wizards have been deprecated; use the class-based '
4141
'views in django.contrib.formtools.wizard.views instead.',
42-
PendingDeprecationWarning)
42+
DeprecationWarning)
4343

4444
def __repr__(self):
4545
return "step: %d\nform_list: %s\ninitial_data: %s" % (self.step, self.form_list, self.initial)

django/contrib/gis/utils/geoip.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ class GeoIP(BaseGeoIP):
1010
def __init__(self, *args, **kwargs):
1111
warnings.warn('GeoIP class has been moved to `django.contrib.gis.geoip`, and '
1212
'this shortcut will disappear in Django v1.6.',
13-
PendingDeprecationWarning, stacklevel=2)
13+
DeprecationWarning, stacklevel=2)
1414
super(GeoIP, self).__init__(*args, **kwargs)

django/contrib/localflavor/uk/forms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import warnings
44
warnings.warn(
55
'The "UK" prefix for United Kingdom has been deprecated in favour of the '
6-
'GB code. Please use the new GB-prefixed names.', PendingDeprecationWarning)
6+
'GB code. Please use the new GB-prefixed names.', DeprecationWarning)
77

88
UKPostcodeField = forms.GBPostcodeField
99
UKCountySelect = forms.GBCountySelect

django/contrib/localflavor/uk/uk_regions.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import warnings
77
warnings.warn(
88
'The "UK" prefix for United Kingdom has been deprecated in favour of the '
9-
'GB code. Please use the new GB-prefixed names.', PendingDeprecationWarning)
9+
'GB code. Please use the new GB-prefixed names.', DeprecationWarning)
1010

1111
UK_NATIONS_CHOICES = GB_NATIONS_CHOICES
1212
UK_REGION_CHOICES = GB_REGION_CHOICES

django/core/cache/backends/memcached.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def __init__(self, server, params):
130130
import warnings
131131
warnings.warn(
132132
"memcached.CacheClass has been split into memcached.MemcachedCache and memcached.PyLibMCCache. Please update your cache backend setting.",
133-
PendingDeprecationWarning
133+
DeprecationWarning
134134
)
135135
try:
136136
import memcache

0 commit comments

Comments
 (0)