You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed the below review comments given by Ashesh Vashi
Instead of having db version string from yml file, user can define the range of
database server version where query is to be executed.
If user want to run the query on database version greater than 10.0.0, use below format.
runonserver: ">=10.0.0"
Below are the example of db version range user can defined in yml file.
<=10.1.0
>=12.1.0
=11.0.0
<9.6.0 || >=11.0.0
log.Debugln("Query skipped for database version: [%s] as it should be run on database server version: [%s]", server.serverversion, mapping.runonserver)
1348
-
continue
1342
+
// check if the query is to be run on specific database server version range or not
log.Debugln("Query skipped for database version: [%s] as it should be run on database server version: [%s]", server.lastMapVersion.String(), mapping.runonserver)
1348
+
continue
1349
+
}
1349
1350
}
1350
1351
1351
1352
scrapeMetric:=false
@@ -1436,7 +1437,6 @@ func (e *Exporter) checkMapVersions(ch chan<- prometheus.Metric, server *Server)
0 commit comments