Skip to content

Commit d4180ec

Browse files
raipubnubClient Engineering Botparfeon
authored
fix - Listener callback is invoked multiple times (#232)
* fix - Listener callback is invoked multiple times * fix lint issue * PubNub SDK v4.34.2 release. * docs: revert bot changes Revert bot changelog entries. * PubNub SDK v4.34.2 release. Co-authored-by: Client Engineering Bot <60980775+Client Engineering [email protected]> Co-authored-by: Serhii Mamontov <[email protected]>
1 parent f206955 commit d4180ec

File tree

15 files changed

+81
-17677
lines changed

15 files changed

+81
-17677
lines changed

.pubnub.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
---
22
changelog:
3+
- date: 2021-12-01
4+
version: v4.34.2
5+
changes:
6+
- type: bug
7+
text: "Fix listener callback is invoked multiple times."
38
- date: 2021-11-19
49
version: v4.34.1
510
changes:
@@ -1042,7 +1047,7 @@ features:
10421047
- FILES-DOWNLOAD-FILE
10431048
time:
10441049
- TIME-TIME
1045-
others:
1050+
others:
10461051
- TELEMETRY
10471052
- CREATE-PUSH-PAYLOAD
10481053
files:
@@ -1071,7 +1076,7 @@ supported-platforms:
10711076
- "Ubuntu 14.04 and up"
10721077
- "Windows 7 and up"
10731078
version: "Pubnub Javascript for Node"
1074-
version: "4.34.1"
1079+
version: "4.34.2"
10751080
sdks:
10761081
-
10771082
full-name: PubNub Javascript SDK
@@ -1090,7 +1095,7 @@ sdks:
10901095
distribution-type: source
10911096
distribution-repository: GitHub release
10921097
package-name: pubnub.js
1093-
location: https://github.com/pubnub/javascript/archive/refs/tags/v4.34.1.zip
1098+
location: https://github.com/pubnub/javascript/archive/refs/tags/v4.34.2.zip
10941099
requires:
10951100
-
10961101
name: "agentkeepalive"
@@ -1854,7 +1859,7 @@ sdks:
18541859
distribution-type: library
18551860
distribution-repository: GitHub release
18561861
package-name: pubnub.js
1857-
location: https://github.com/pubnub/javascript/releases/download/v4.34.1/pubnub.4.34.1.js
1862+
location: https://github.com/pubnub/javascript/releases/download/v4.34.2/pubnub.4.34.2.js
18581863
requires:
18591864
-
18601865
name: "agentkeepalive"

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## v4.34.2
2+
December 01 2021
3+
4+
#### Fixed
5+
- Fix listener callback is invoked multiple times. Fixed the following issues reported by [@puopg](https://github.com/puopg): [#230](https://github.com/pubnub/javascript/issues/230).
6+
17
## v4.34.1
28
November 19 2021
39

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ You will need the publish and subscribe keys to authenticate your app. Get your
2222
npm install pubnub
2323
```
2424
* or download one of our builds from our CDN:
25-
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.34.1.js
26-
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.34.1.min.js
25+
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.34.2.js
26+
* https://cdn.pubnub.com/sdk/javascript/pubnub.4.34.2.min.js
2727
2828
2. Configure your keys:
2929

dist/titanium/pubnub.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! 4.34.1 / Consumer */
1+
/*! 4.34.2 / Consumer */
22
exports["PubNub"] =
33
/******/ (function(modules) { // webpackBootstrap
44
/******/ // The module cache
@@ -575,7 +575,7 @@ var _default = function () {
575575
}, {
576576
key: "getVersion",
577577
value: function getVersion() {
578-
return '4.34.1';
578+
return '4.34.2';
579579
}
580580
}, {
581581
key: "_addPnsdkSuffix",

dist/titanium/pubnub.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/web/pubnub.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! 4.34.1 / Consumer */
1+
/*! 4.34.2 / Consumer */
22
(function webpackUniversalModuleDefinition(root, factory) {
33
if(typeof exports === 'object' && typeof module === 'object')
44
module.exports = factory();
@@ -585,7 +585,7 @@ var _default = function () {
585585
}, {
586586
key: "getVersion",
587587
value: function getVersion() {
588-
return '4.34.1';
588+
return '4.34.2';
589589
}
590590
}, {
591591
key: "_addPnsdkSuffix",
@@ -16396,7 +16396,8 @@ function xdr(superagentConstruct, endpoint, callback) {
1639616396
sc = sc.buffer(false);
1639716397
}
1639816398

16399-
return sc.timeout(endpoint.timeout).end(function (err, resp) {
16399+
sc = sc.timeout(endpoint.timeout);
16400+
sc.end(function (err, resp) {
1640016401
var parsedResponse;
1640116402
var status = {};
1640216403
status.error = err !== null;
@@ -16449,6 +16450,7 @@ function xdr(superagentConstruct, endpoint, callback) {
1644916450

1645016451
return callback(status, parsedResponse);
1645116452
});
16453+
return sc;
1645216454
}
1645316455

1645416456
function postfile(_x, _x2, _x3) {

dist/web/pubnub.min.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/core/components/config.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/core/components/config.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/networking/modules/web-node.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/networking/modules/web-node.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)