Import all friendly submodules before settings limits

Author: alexmojaki

backend/main/tests/test_transcript.json

@@ -3517,7 +3517,7 @@
                                     ]
                                 }
                             ],
-                            "friendly": "<p>An <code>IndexError</code> occurs when you are try to get an item from a list,\na tuple, or a similar object (sequence), by using an index which\ndoes not exists; typically, this is because the index you give\nis greater than the length of the sequence.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>An <code>IndexError</code> occurs when you are try to get an item from a list,\na tuple, or a similar object (sequence), by using an index which\ndoes not exists; typically, this is because the index you give\nis greater than the length of the sequence.</p>\n<p>You have tried to get the item with index <code>4</code> of <code>words</code>,\na <code>list</code> of length <code>4</code>.\nThe largest valid index of <code>words</code> is <code>3</code>.</p>",
                             "tail": ""
                         }
                     ]
@@ -4125,7 +4125,7 @@
                                     ]
                                 }
                             ],
-                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>The parenthesis <code>()</code> following <code>f</code> are interpreted\nby Python as a function call for <code>f</code>.\nHowever, <code>f</code> is not a function but an object of type <code>str</code>.</p>",
                             "tail": ""
                         }
                     ]
@@ -4226,7 +4226,7 @@
                                     ]
                                 }
                             ],
-                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>No information is known about this exception.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>\n<p>If you are using the Friendly console, use <code>www()</code> to\ndo an Internet search for this particular case.</p>",
                             "tail": ""
                         }
                     ]
@@ -4316,7 +4316,7 @@
                                     ]
                                 }
                             ],
-                            "friendly": "<p>An <code>AttributeError</code> occurs when the code contains something like\n    <code>object.x</code>\nand <code>x</code> is not a method or attribute (variable) belonging to <code>object</code>.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>An <code>AttributeError</code> occurs when the code contains something like\n    <code>object.x</code>\nand <code>x</code> is not a method or attribute (variable) belonging to <code>object</code>.</p>\n<p>The object <code>word</code> has no attribute named <code>append</code>.\nThe following are some of its known attributes:\n<code>capitalize, casefold, center, count, encode, endswith, expandtabs, find, format, ...</code>.</p>",
                             "tail": ""
                         }
                     ]
@@ -5038,7 +5038,7 @@
                                     "variables": []
                                 }
                             ],
-                            "friendly": "<p>An <code>AttributeError</code> occurs when the code contains something like\n    <code>object.x</code>\nand <code>x</code> is not a method or attribute (variable) belonging to <code>object</code>.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>An <code>AttributeError</code> occurs when the code contains something like\n    <code>object.x</code>\nand <code>x</code> is not a method or attribute (variable) belonging to <code>object</code>.</p>\n<p>The object <code>'Python'</code> has no attribute named <code>append</code>.\nThe following are some of its known attributes:\n<code>capitalize, casefold, center, count, encode, endswith, expandtabs, find, format, ...</code>.</p>",
                             "tail": ""
                         }
                     ]
@@ -5425,7 +5425,7 @@
                                     ]
                                 }
                             ],
-                            "friendly": "<p>An <code>IndexError</code> occurs when you are try to get an item from a list,\na tuple, or a similar object (sequence), by using an index which\ndoes not exists; typically, this is because the index you give\nis greater than the length of the sequence.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>An <code>IndexError</code> occurs when you are try to get an item from a list,\na tuple, or a similar object (sequence), by using an index which\ndoes not exists; typically, this is because the index you give\nis greater than the length of the sequence.</p>",
                             "tail": ""
                         }
                     ]
@@ -5797,7 +5797,7 @@
                                     ]
                                 }
                             ],
-                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>You tried to concatenate (add) two different types of objects:\na string (<code>str</code>) and an integer (<code>int</code>).</p>",
                             "tail": ""
                         }
                     ]
@@ -6107,7 +6107,7 @@
                                     "variables": []
                                 }
                             ],
-                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>You tried to add two incompatible types of objects:\nan integer (<code>int</code>) and a string (<code>str</code>).</p>",
                             "tail": ""
                         }
                     ]
@@ -15995,7 +15995,7 @@
                                     "variables": []
                                 }
                             ],
-                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>Internal error for Friendly-traceback.\nPlease report this example to\nhttps://github.com/aroberge/friendly-traceback/issues</p>",
+                            "friendly": "<p>A <code>TypeError</code> is usually caused by trying\nto combine two incompatible types of objects,\nby calling a function with the wrong type of object,\nor by trying to do an operation not allowed on a given type of object.</p>\n<p>You tried to add two incompatible types of objects:\nan integer (<code>int</code>) and a string (<code>str</code>).\nPerhaps you forgot to convert the string <code>'34'</code> into an integer (<code>int</code>).</p>",
                             "tail": ""
                         }
                     ]

backend/main/workers/limits.py

@@ -4,8 +4,10 @@
 import sys
 from functools import lru_cache
 from importlib import import_module
-
-from main.utils import get_suggestions_for_exception
+import friendly.runtime_errors
+import friendly.syntax_errors
+from main.workers.tracebacks import TracebackSerializer
+from main.workers.utils import import_submodules
 
 
 def patch_cwd():
@@ -35,22 +37,14 @@ def set_limits():
 
     # Trigger imports before limiting access to files
     from main.workers import birdseye, snoop  # noqa
-    from friendly_traceback.runtime_errors import (  # noqa
-        type_error,
-        attribute_error,
-        stdlib,
-    )
-    from friendly_traceback.syntax_errors import (  # noqa
-        analyze_syntax,
-        line_analyzer,
-        message_analyzer,
-        source_analyzer,
-    )
+    import_submodules(friendly.runtime_errors)
+    import_submodules(friendly.syntax_errors)
 
-    try:
-        sdfsdfsdfsd  # noqa
-    except NameError as e:
-        list(get_suggestions_for_exception(e, e.__traceback__))
+    for bad_code in ["nameerror", "syntax error", "1 + '2'", "list.set", "[][0]", "{}[0]"]:
+        try:
+            eval(bad_code)  # noqa
+        except Exception as e:
+            TracebackSerializer().format_exception(e)
 
     # Put all modules in linecache so that tracebacks work
     for mod in list(sys.modules.values()):

backend/main/workers/utils.py

@@ -1,3 +1,5 @@
+import importlib
+import pkgutil
 import json
 import multiprocessing.queues
 import sys
@@ -127,3 +129,20 @@ def dumps(self, x):
 
 
 multiprocessing.queues._ForkingPickler = json_pickler = JsonPickler()
+
+
+def import_submodules(package, recursive=True):
+    """
+    Import all submodules of a module, recursively, including subpackages
+
+    https://stackoverflow.com/questions/3365740/how-to-import-all-submodules
+    """
+    if isinstance(package, str):
+        package = importlib.import_module(package)
+    results = {}
+    for loader, name, is_pkg in pkgutil.walk_packages(package.__path__):
+        full_name = package.__name__ + '.' + name
+        results[full_name] = importlib.import_module(full_name)
+        if recursive and is_pkg:
+            results.update(import_submodules(full_name))
+    return results