Skip to content

Commit 395777d

Browse files
committed
<third_party/angle> Fix crash in TSymbolTableLevel::~TSymbolTableLevel with gcc 4.9
WebGL crashes when chromium is compiled with gcc 4.9, because TSymbolTableLevel::~TSymbolTableLevel does double delete of e.g. TFunctions because they are inserted in the table with both their name and mangled name. The fix for this should reach stable with m37. https://code.google.com/p/angleproject/issues/detail?id=651 Patch by Mike Hommey <[email protected]> https://bugzilla.mozilla.org/show_bug.cgi?id=1025576 Change-Id: I0571478759666bcb55633dd4e630c5b42216d949 Reviewed-by: Jocelyn Turcotte <[email protected]>
1 parent 622cb04 commit 395777d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

chromium/third_party/angle/src/compiler/SymbolTable.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,8 @@ TFunction::~TFunction()
171171
TSymbolTableLevel::~TSymbolTableLevel()
172172
{
173173
for (tLevel::iterator it = level.begin(); it != level.end(); ++it)
174-
delete (*it).second;
174+
if ((*it).first == (*it).second->getMangledName())
175+
delete (*it).second;
175176
}
176177

177178
//

0 commit comments

Comments
 (0)