Skip to content

Commit add08d5

Browse files
mnegyokruAllan Sandfeld Jensen
authored and
Allan Sandfeld Jensen
committed
[fixup] Add minimal webrtcdesktopcapture api for hangout services extension
Fixes "Check failed: false. Error validating response to `webrtcDesktopCapturePrivate.chooseDesktopMedia`: Missing required argument 'streamId'." error after rejecting the request. Change-Id: I3f211f7cca9a7364390f6e077bd108036bde0eef Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/619076 Reviewed-by: Allan Sandfeld Jensen <[email protected]> (cherry picked from commit fd5eb50) Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/621130 Reviewed-by: Qt Cherry-pick Bot <[email protected]>
1 parent c4aa5cc commit add08d5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

chromium/qtwebengine/browser/extensions/api/webrtc_desktop_capture_private/webrtc_desktop_capture_private_api.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@ void WebrtcDesktopCapturePrivateChooseDesktopMediaFunction::ProcessAccessRequest
140140
{
141141
if (stream_request_result != blink::mojom::MediaStreamRequestResult::OK) {
142142
// The request is canceled either by the desktopMediaRequest or the permission request.
143-
// Respond with no arguments to mimic DesktopCaptureCancelChooseDesktopMediaFunctionBase::Run()
143+
// Respond with no arguments to mimic DesktopCaptureChooseDesktopMediaFunctionBase::Cancel()
144144
// form desktop_capture_base.cc.
145-
Respond(NoArguments());
145+
Respond(ArgumentList(Create(std::string(), Options())));
146146
return;
147147
}
148148

0 commit comments

Comments
 (0)