Skip to content

Commit bcde3a8

Browse files
committed
Revert "Restore GLX usage"
This reverts commit eb94d3a. Change-Id: I057e10ae27ca115aa085a34e6d8a3f433b389580 Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/596600 Reviewed-by: Allan Sandfeld Jensen <[email protected]>
1 parent 81cbdb4 commit bcde3a8

18 files changed

+9
-2565
lines changed

chromium/tools/v8_context_snapshot/qt_overrides.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ bool GLSurfaceGLX::IsCreateContextES2ProfileSupported() {
4040
bool GLSurfaceGLX::IsCreateContextSupported() {
4141
return false;
4242
}
43+
bool GLSurfaceGLX::InitializeExtensionSettingsOneOff() {
44+
return false;
45+
}
4346
} // namespace gl
4447
#endif // if BUILDFLAG(IS_LINUX) && BUILDFLAG(IS_OZONE_X11)
4548

chromium/ui/gl/BUILD.gn

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@ declare_args() {
1919
# Whether service side logging (actual calls into the GL driver) is enabled
2020
# or not.
2121
enable_gpu_service_logging = false
22-
use_glx = false
2322
}
2423

25-
use_glx = ozone_platform_x11
26-
2724
if (is_android) {
2825
import("//build/config/android/config.gni")
2926
import("//build/config/android/rules.gni")
@@ -44,11 +41,6 @@ buildflag_header("buildflags") {
4441

4542
config("gl_config") {
4643
defines = []
47-
if (use_glx) {
48-
defines += [
49-
"USE_GLX",
50-
]
51-
}
5244
if (use_egl) {
5345
defines += [ "USE_EGL" ]
5446
}
@@ -274,8 +266,6 @@ jumbo_component("gl") {
274266
"gl_surface_egl_x11.h",
275267
"gl_surface_egl_x11_gles2.cc",
276268
"gl_surface_egl_x11_gles2.h",
277-
"gl_surface_glx_x11.cc",
278-
"gl_surface_glx_x11.h",
279269
]
280270

281271
deps += [
@@ -295,23 +285,6 @@ jumbo_component("gl") {
295285
}
296286
}
297287

298-
if (use_glx) {
299-
sources += [
300-
"gl_bindings_autogen_glx.cc",
301-
"gl_bindings_autogen_glx.h",
302-
"gl_context_glx.cc",
303-
"gl_context_glx.h",
304-
"gl_glx_api_implementation.cc",
305-
"gl_glx_api_implementation.h",
306-
"gl_surface_glx.h",
307-
]
308-
309-
deps += [
310-
"//ui/base/x",
311-
"//ui/gfx/x",
312-
]
313-
}
314-
315288
if (is_win) {
316289
sources += [
317290
"child_window_win.cc",
@@ -596,10 +569,6 @@ test("gl_unittests") {
596569
]
597570
}
598571

599-
if (use_glx) {
600-
sources += [ "glx_api_unittest.cc" ]
601-
}
602-
603572
if (is_win) {
604573
sources += [
605574
"dcomp_presenter_unittest.cc",

chromium/ui/gl/gl_bindings.h

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
#include <GL/wglext.h>
3737
#elif BUILDFLAG(IS_MAC)
3838
#include <OpenGL/OpenGL.h>
39-
#elif defined(USE_GLX)
39+
#elif BUILDFLAG(IS_LINUX)
4040
using Display = struct _XDisplay;
4141
using Bool = int;
4242
using Status = int;
@@ -45,18 +45,6 @@ using Colormap = XID;
4545
using Font = XID;
4646
using Pixmap = XID;
4747
using Window = XID;
48-
using GLXPixmap = XID;
49-
using GLXWindow = XID;
50-
using GLXDrawable = XID;
51-
using GLXPbuffer = XID;
52-
using GLXContextID = XID;
53-
using GLXContext = struct __GLXcontextRec*;
54-
using GLXFBConfig = struct __GLXFBConfigRec*;
55-
struct XVisualInfo;
56-
57-
58-
#include <GL/glxext.h>
59-
#include <GL/glxtokens.h>
6048
#endif
6149

6250
// GLES2 defines not part of Desktop GL
@@ -547,12 +535,7 @@ struct GL_EXPORT DriverEGL {
547535
#if defined(USE_GLX)
548536
struct GL_EXPORT DriverGLX {
549537
void InitializeStaticBindings();
550-
#if BUILDFLAG(IS_QTWEBENGINE)
551-
void InitializeExtensionBindings(const std::string&);
552-
#else
553538
void InitializeExtensionBindings();
554-
#endif
555-
556539
void ClearBindings();
557540

558541
ProcsGLX fn;

chromium/ui/gl/gl_bindings_api_autogen_glx.h

Lines changed: 0 additions & 137 deletions
This file was deleted.

0 commit comments

Comments
 (0)