Skip to content

Commit 2e78e36

Browse files
committed
WebSocket Server refactor
The variable is used only once. The function can be used in the condition. An error message is shown when the WebSocket Server fails to listen. Change-Id: Ia5b54d271ed72bc408d94d24eb275f7d83f290f1 Reviewed-by: Edward Welbourne <[email protected]> Reviewed-by: Mårten Nordheim <[email protected]> Reviewed-by: Michael Brasser <[email protected]>
1 parent bc8fefc commit 2e78e36

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/plugins/platforms/webgl/qwebglwebsocketserver.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,13 @@ void QWebGLWebSocketServer::create()
145145
{
146146
Q_D(QWebGLWebSocketServer);
147147
d->server = new QWebSocketServer(QLatin1String("qtwebgl"), QWebSocketServer::NonSecureMode);
148-
bool ok = d->server->listen(QHostAddress::Any);
149-
if (ok)
150-
connect(d->server, &QWebSocketServer::newConnection, this,
151-
&QWebGLWebSocketServer::onNewConnection);
148+
if (d->server->listen(QHostAddress::Any)) {
149+
connect(d->server, &QWebSocketServer::newConnection,
150+
this, &QWebGLWebSocketServer::onNewConnection);
151+
} else {
152+
qCCritical(lc, "The WebSocket Server cannot start: %s",
153+
qPrintable(d->server->errorString()));
154+
}
152155

153156
QMutexLocker lock(&QWebGLIntegrationPrivate::instance()->waitMutex);
154157
QWebGLIntegrationPrivate::instance()->waitCondition.wakeAll();

0 commit comments

Comments
 (0)