Skip to content

Commit 9bed50d

Browse files
committed
Remove FIXME comments
Verified from Gerrit core code that these lines can be removed. Change-Id: Ie1af82298fe40b35bfd1d9e2869e5d754e0d356d Reviewed-by: Paul Wicking <[email protected]>
1 parent 48b9c48 commit 9bed50d

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/main/java/com/googlesource/gerrit/plugins/qtcodereview/QtChangeUpdateOp.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public boolean updateChange(ChangeContext ctx) throws IOException, ResourceConfl
105105

106106
ChangeUpdate newPsUpdate = ctx.getUpdate(psId);
107107

108-
saveApprovals(normalized, ctx, newPsUpdate, true);
108+
saveApprovals(normalized, newPsUpdate, true);
109109
submitter = convertPatchSet(psId).apply(submitter);
110110
updated = true;
111111
}
@@ -148,20 +148,12 @@ private LabelNormalizer.Result approve(ChangeContext ctx, ChangeUpdate update)
148148

149149
LabelNormalizer.Result normalized = labelNormalizer.normalize(ctx.getNotes(), byKey.values());
150150
update.putApproval(submitter.getLabel(), submitter.getValue());
151-
saveApprovals(normalized, ctx, update, false);
151+
saveApprovals(normalized, update, false);
152152
return normalized;
153153
}
154154

155155
private void saveApprovals(
156-
LabelNormalizer.Result normalized,
157-
ChangeContext ctx,
158-
ChangeUpdate update,
159-
boolean includeUnchanged) {
160-
PatchSet.Id psId = update.getPatchSetId();
161-
// FIXME, can this simply be removed?
162-
// ctx.patchSetApprovals().upsert(convertPatchSet(normalized.getNormalized(), psId));
163-
// FIXME, can this simply be removed?
164-
// ctx.patchSetApprovals().upsert(zero(convertPatchSet(normalized.deleted(), psId)));
156+
LabelNormalizer.Result normalized, ChangeUpdate update, boolean includeUnchanged) {
165157
for (PatchSetApproval psa : normalized.updated()) {
166158
update.putApprovalFor(psa.getAccountId(), psa.getLabel(), psa.getValue());
167159
}

0 commit comments

Comments
 (0)