[GR-24012] UnicodeData module doesn't have name method.

PullRequest: graalpython/1125

Author: ppisl

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_ucn.txt

@@ -1,6 +1,11 @@
+*graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_aliases_names_in_pua_range
+*graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_ascii_letters
 *graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_cjk_unified_ideographs
+*graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_errors
 *graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_general
+*graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_hangul_syllables
 *graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_issue16335
 *graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_misc_symbols
 *graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_named_sequences_full
+*graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_named_sequences_names_in_pua_range
 *graalpython.lib-python.3.test.test_ucn.UnicodeNamesTest.test_strict_error_handling

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/UnicodeDataModuleBuiltins.java

@@ -40,6 +40,9 @@
  */
 package com.oracle.graal.python.builtins.modules;
 
+import com.ibm.icu.lang.UCharacter;
+
+import static com.oracle.graal.python.runtime.exception.PythonErrorType.TypeError;
 import static com.oracle.graal.python.runtime.exception.PythonErrorType.ValueError;
 
 import java.text.Normalizer;
@@ -49,6 +52,7 @@
 import com.oracle.graal.python.builtins.CoreFunctions;
 import com.oracle.graal.python.builtins.PythonBuiltinClassType;
 import com.oracle.graal.python.builtins.PythonBuiltins;
+import com.oracle.graal.python.builtins.objects.PNone;
 import com.oracle.graal.python.builtins.objects.object.PythonObject;
 import com.oracle.graal.python.builtins.objects.str.PString;
 import com.oracle.graal.python.builtins.objects.type.PythonBuiltinClass;
@@ -60,6 +64,7 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.GenerateNodeFactory;
 import com.oracle.truffle.api.dsl.NodeFactory;
 import com.oracle.truffle.api.dsl.Specialization;
@@ -245,4 +250,52 @@ public boolean normalize(String form, PString unistr,
             }
         }
     }
+
+    // unicodedata.name(char, defaultValue)
+    @Builtin(name = "name", minNumOfPositionalArgs = 1, maxNumOfPositionalArgs = 2)
+    @GenerateNodeFactory
+    public abstract static class NameNode extends PythonBuiltinNode {
+
+        @TruffleBoundary
+        protected Object getName(String chr, Object defaultValue) {
+            if (chr.codePointCount(0, chr.length()) != 1) {
+                throw raise(TypeError, ErrorMessages.ARG_MUST_BE_UNICODE, "name()", 1, chr);
+            }
+            int cp = Character.codePointAt(chr, 0);
+            if ((0xe000 <= cp && cp <= 0xf8ff) || (0xF0000 <= cp && cp <= 0xFFFFD) || (0x100000 <= cp && cp <= 0x10FFFD)) {
+                // do not populate names from private use areas
+                throw raise(ValueError, ErrorMessages.NO_SUCH_NAME);
+            }
+            String result = UCharacter.getName(cp);
+            if (result == null) {
+                if (defaultValue == PNone.NO_VALUE) {
+                    throw raise(ValueError, ErrorMessages.NO_SUCH_NAME);
+                }
+                return defaultValue;
+            }
+            return result;
+        }
+
+        @Specialization
+        public Object name(String chr, Object defaultValue) {
+            return getName(chr, defaultValue);
+        }
+
+        @Specialization
+        public Object name(PString pchr, Object defaultValue,
+                        @Cached CastToJavaStringNode castToJavaStringNode) {
+            String chr;
+            try {
+                chr = castToJavaStringNode.execute(pchr);
+            } catch (CannotCastException e) {
+                throw CompilerDirectives.shouldNotReachHere(e);
+            }
+            return getName(chr, defaultValue);
+        }
+
+        @Fallback
+        public Object name(Object chr, @SuppressWarnings("unused") Object defaultValue) {
+            throw raise(TypeError, ErrorMessages.ARG_MUST_BE_UNICODE, "name()", 1, chr);
+        }
+    }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/ErrorMessages.java

@@ -354,6 +354,7 @@ public abstract class ErrorMessages {
     public static final String NO_CURRENT_FRAME = "%s: no current frame";
     public static final String NO_FUNCTION_FOUND = "no function %s%s found in %s";
     public static final String NO_SUCH_FILE_OR_DIR = "No such file or directory: '%s:/%s'";
+    public static final String NO_SUCH_NAME = "no such name";
     public static final String NONLOCAL_AND_GLOBAL = "name '%s' is nonlocal and global";
     public static final String NONLOCAL_AT_MODULE_LEVEL = "nonlocal declaration not allowed at module level";
     public static final String NON_HEX_DIGIT_FOUND = "Non-hexadecimal digit found";