Skip to content

Commit b395845

Browse files
committed
merge with master repo
with conflicts
2 parents f1f1ee1 + b370051 commit b395845

File tree

7 files changed

+19
-221
lines changed

7 files changed

+19
-221
lines changed

app/js/timer.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,14 @@ angular.module('timer', [])
1313
},
1414
controller: ['$scope', '$element', '$attrs', '$timeout', function ($scope, $element, $attrs, $timeout) {
1515

16+
// Checking for trim function since IE8 doesn't have it
17+
// If not a function, create tirm with RegEx to mimic native trim
18+
if(typeof String.prototype.trim !== 'function') {
19+
String.prototype.trim = function() {
20+
return this.replace(/^\s+|\s+$/g, '');
21+
};
22+
}
23+
1624
//angular 1.2 doesn't support attributes ending in "-start", so we're
1725
//supporting both "autostart" and "auto-start" as a solution for
1826
//backward and forward compatibility.

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"author": "Siddique Hameed",
33
"name": "angular-timer",
4-
"version": "1.0.12",
4+
"version": "1.1.0",
55
"homepage": "https://github.com/siddii/angular-timer",
66
"description": "Angular-Timer : A simple AngularJS directive demonstrating re-usability & interoperability",
77
"repository": {

dist/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
##Change Log
22

3+
###Version 1.1.0
4+
* Plural/singular units. PR - https://github.com/siddii/angular-timer/pull/54
5+
* IE8 support. PR - https://github.com/siddii/angular-timer/pull/62
6+
37
###Version 1.0.12
48
* `clear` method. Please see this PR - https://github.com/siddii/angular-timer/pull/43
59

dist/angular-timer.js

Lines changed: 0 additions & 208 deletions
This file was deleted.

dist/angular-timer.min.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

index.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,13 +168,15 @@ <h3>Plural / Singular units</h3>
168168
<div class="bs-docs-example">
169169
<p>
170170
Two stopped countdown timers to illustrate how to handle pluralization of time units.
171-
<code ng-non-bindable="">
171+
<code ng-non-bindable="">
172172
&lt;timer autostart="false" countdown="90061"&gt;{{days}} day{{daysS}}, {{hours}} hour{{hoursS}}, {{minutes}} minute{{minutesS}}, {{seconds}} second{{secondsS}}.&lt;/timer&gt;
173-
</code>
174-
173+
</code>
175174
<h3 class="singular-counter">
176175
<timer autostart="false" countdown="90061">{{days}} day{{daysS}}, {{hours}} hour{{hoursS}}, {{minutes}} minute{{minutesS}}, {{seconds}} second{{secondsS}}.</timer>
177176
</h3>
177+
<code ng-non-bindable="">
178+
&lt;timer autostart="false" countdown="190061"&gt;{{days}} day{{daysS}}, {{hours}} hour{{hoursS}}, {{minutes}} minute{{minutesS}}, {{seconds}} second{{secondsS}}.&lt;/timer&gt;
179+
</code>
178180
<h3 class="plural-counter">
179181
<timer autostart="false" countdown="190061">{{days}} day{{daysS}}, {{hours}} hour{{hoursS}}, {{minutes}} minute{{minutesS}}, {{seconds}} second{{secondsS}}.</timer>
180182
</h3>

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"author": "Siddique Hameed",
33
"name": "angular-timer",
4-
"version": "1.0.12",
4+
"version": "1.1.0",
55
"homepage": "https://github.com/siddii/angular-timer",
66
"licenses": {
77
"type": "MIT",

0 commit comments

Comments
 (0)