Skip to content

Commit 6f21b10

Browse files
refactoring: Sonar CRITICAL issue fixes (iluwatar#2176)
1 parent c8fa1a5 commit 6f21b10

File tree

1 file changed

+20
-13
lines changed
  • special-case/src/main/java/com/iluwatar/specialcase

1 file changed

+20
-13
lines changed

special-case/src/main/java/com/iluwatar/specialcase/App.java

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,35 +37,42 @@ public class App {
3737

3838
private static final Logger LOGGER = LoggerFactory.getLogger(App.class);
3939

40+
private static final String LOGGER_STRING = "[REQUEST] User: {} buy product: {}";
41+
private static final String TEST_USER_1 = "ignite1771";
42+
private static final String TEST_USER_2 = "abc123";
43+
private static final String ITEM_TV = "tv";
44+
private static final String ITEM_CAR = "car";
45+
private static final String ITEM_COMPUTER = "computer";
46+
4047
/**
4148
* Program entry point.
4249
*/
4350
public static void main(String[] args) {
4451
// DB seeding
4552
LOGGER.info("Db seeding: " + "1 user: {\"ignite1771\", amount = 1000.0}, "
4653
+ "2 products: {\"computer\": price = 800.0, \"car\": price = 20000.0}");
47-
Db.getInstance().seedUser("ignite1771", 1000.0);
48-
Db.getInstance().seedItem("computer", 800.0);
49-
Db.getInstance().seedItem("car", 20000.0);
54+
Db.getInstance().seedUser(TEST_USER_1, 1000.0);
55+
Db.getInstance().seedItem(ITEM_COMPUTER, 800.0);
56+
Db.getInstance().seedItem(ITEM_CAR, 20000.0);
5057

5158
final var applicationServices = new ApplicationServicesImpl();
5259
ReceiptViewModel receipt;
5360

54-
LOGGER.info("[REQUEST] User: " + "abc123" + " buy product: " + "tv");
55-
receipt = applicationServices.loggedInUserPurchase("abc123", "tv");
61+
LOGGER.info(LOGGER_STRING, TEST_USER_2, ITEM_TV);
62+
receipt = applicationServices.loggedInUserPurchase(TEST_USER_2, ITEM_TV);
5663
receipt.show();
5764
MaintenanceLock.getInstance().setLock(false);
58-
LOGGER.info("[REQUEST] User: " + "abc123" + " buy product: " + "tv");
59-
receipt = applicationServices.loggedInUserPurchase("abc123", "tv");
65+
LOGGER.info(LOGGER_STRING, TEST_USER_2, ITEM_TV);
66+
receipt = applicationServices.loggedInUserPurchase(TEST_USER_2, ITEM_TV);
6067
receipt.show();
61-
LOGGER.info("[REQUEST] User: " + "ignite1771" + " buy product: " + "tv");
62-
receipt = applicationServices.loggedInUserPurchase("ignite1771", "tv");
68+
LOGGER.info(LOGGER_STRING, TEST_USER_1, ITEM_TV);
69+
receipt = applicationServices.loggedInUserPurchase(TEST_USER_1, ITEM_TV);
6370
receipt.show();
64-
LOGGER.info("[REQUEST] User: " + "ignite1771" + " buy product: " + "car");
65-
receipt = applicationServices.loggedInUserPurchase("ignite1771", "car");
71+
LOGGER.info(LOGGER_STRING, TEST_USER_1, ITEM_CAR);
72+
receipt = applicationServices.loggedInUserPurchase(TEST_USER_1, ITEM_CAR);
6673
receipt.show();
67-
LOGGER.info("[REQUEST] User: " + "ignite1771" + " buy product: " + "computer");
68-
receipt = applicationServices.loggedInUserPurchase("ignite1771", "computer");
74+
LOGGER.info(LOGGER_STRING, TEST_USER_1, ITEM_COMPUTER);
75+
receipt = applicationServices.loggedInUserPurchase(TEST_USER_1, ITEM_COMPUTER);
6976
receipt.show();
7077
}
7178
}

0 commit comments

Comments
 (0)