Skip to content

Commit adb0e25

Browse files
refactor: Fix for maven warnings (iluwatar#2157)
* fix for maven warnings * Removed unwanted dependency and htmlunit upgraded to latest Co-authored-by: Mohana Rao S V <[email protected]>
1 parent cd736d7 commit adb0e25

File tree

4 files changed

+5
-9
lines changed

4 files changed

+5
-9
lines changed

metadata-mapping/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,6 @@
4646
<groupId>org.hibernate</groupId>
4747
<artifactId>hibernate-core</artifactId>
4848
</dependency>
49-
<dependency>
50-
<groupId>com.h2database</groupId>
51-
<artifactId>h2</artifactId>
52-
</dependency>
5349
<dependency>
5450
<groupId>javax.xml.bind</groupId>
5551
<artifactId>jaxb-api</artifactId>

page-object/test-automation/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<dependencies>
3737
<dependency>
3838
<groupId>org.junit.jupiter</groupId>
39-
<artifactId>junit-jupiter-engine</artifactId>
39+
<artifactId>junit-jupiter-api</artifactId>
4040
<scope>test</scope>
4141
</dependency>
4242
<dependency>

page-object/test-automation/src/main/java/com/iluwatar/pageobject/AlbumListPage.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,11 @@ public boolean isAt() {
8080
*/
8181
public AlbumPage selectAlbum(String albumTitle) {
8282
// uses XPath to find list of html anchor tags with the class album in it
83-
var albumLinks = (List<HtmlAnchor>) page.getByXPath("//tr[@class='album']//a");
83+
var albumLinks = (List<Object>) page.getByXPath("//tr[@class='album']//a");
8484
for (var anchor : albumLinks) {
85-
if (anchor.getTextContent().equals(albumTitle)) {
85+
if (((HtmlAnchor) anchor).getTextContent().equals(albumTitle)) {
8686
try {
87-
anchor.click();
87+
((HtmlAnchor) anchor).click();
8888
return new AlbumPage(webClient);
8989
} catch (IOException e) {
9090
LOGGER.error("An error occured on selectAlbum", e);

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
<camel.version>2.25.1</camel.version>
4444
<guava.version>19.0</guava.version>
4545
<mockito.version>3.5.6</mockito.version>
46-
<htmlunit.version>2.22</htmlunit.version>
46+
<htmlunit.version>2.66.0</htmlunit.version>
4747
<guice.version>4.0</guice.version>
4848
<mongo-java-driver.version>3.12.8</mongo-java-driver.version>
4949
<aws-lambda-core.version>1.1.0</aws-lambda-core.version>

0 commit comments

Comments
 (0)