Fix issues identified by running tests on PHP 8

Author: sebastianbergmann

src/Report/Crap4j.php

@@ -65,7 +65,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
 
             foreach ($classes as $className => $class) {
                 foreach ($class['methods'] as $methodName => $method) {
-                    $crapLoad = $this->getCrapLoad($method['crap'], $method['ccn'], $method['coverage']);
+                    $crapLoad = $this->getCrapLoad((float) $method['crap'], $method['ccn'], $method['coverage']);
 
                     $fullCrap += $method['crap'];
                     $fullCrapLoad += $crapLoad;
@@ -86,7 +86,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
                     $methodNode->appendChild($document->createElement('methodName', $methodName));
                     $methodNode->appendChild($document->createElement('methodSignature', \htmlspecialchars($method['signature'])));
                     $methodNode->appendChild($document->createElement('fullMethod', \htmlspecialchars($method['signature'])));
-                    $methodNode->appendChild($document->createElement('crap', (string) $this->roundValue($method['crap'])));
+                    $methodNode->appendChild($document->createElement('crap', (string) $this->roundValue((float) $method['crap'])));
                     $methodNode->appendChild($document->createElement('complexity', (string) $method['ccn']));
                     $methodNode->appendChild($document->createElement('coverage', (string) $this->roundValue($method['coverage'])));
                     $methodNode->appendChild($document->createElement('crapLoad', (string) \round($crapLoad)));
@@ -133,12 +133,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
         return $buffer;
     }
 
-    /**
-     * @param float $crapValue
-     * @param int   $cyclomaticComplexity
-     * @param float $coveragePercent
-     */
-    private function getCrapLoad($crapValue, $cyclomaticComplexity, $coveragePercent): float
+    private function getCrapLoad(float $crapValue, int $cyclomaticComplexity, float $coveragePercent): float
     {
         $crapLoad = 0;
 
@@ -150,10 +145,7 @@ private function getCrapLoad($crapValue, $cyclomaticComplexity, $coveragePercent
         return $crapLoad;
     }
 
-    /**
-     * @param float $value
-     */
-    private function roundValue($value): float
+    private function roundValue(float $value): float
     {
         return \round($value, 2);
     }