Relaxed finality of some classes in AMQP appender module.

Author: cipriancraciun

logback-amqp-appender/src/main/java/ch/qos/logback/amqp/AmqpAppender.java

@@ -16,27 +16,67 @@
 import ch.qos.logback.core.UnsynchronizedAppenderBase;
 
 
-public final class AmqpAppender
+public class AmqpAppender
 		extends UnsynchronizedAppenderBase<ILoggingEvent>
 {
 	public AmqpAppender ()
 	{
 		super ();
-		this.serializer = new DefaultBinarySerializer ();
 		this.buffer = new LinkedBlockingDeque<AmqpMessage> ();
 		this.exchangeLayout = new PatternLayout ();
 		this.routingKeyLayout = new PatternLayout ();
 		this.exchangeLayout.setPattern (AmqpAppender.defaultExchangeKeyPattern);
 		this.routingKeyLayout.setPattern (AmqpAppender.defaultRoutingKeyPattern);
 		this.mutator = new DefaultMutator ();
+		this.serializer = new DefaultBinarySerializer ();
 		this.publisher = null;
 	}
 
+	public final String getExchangePattern ()
+	{
+		return (this.exchangeLayout.getPattern ());
+	}
+	
+	public final String getHost ()
+	{
+		return (this.host);
+	}
+	
 	public final Mutator getMutator ()
 	{
 		return (this.mutator);
 	}
 
+	public final String getPassword ()
+	{
+		return (this.password);
+	}
+	
+	public final Integer getPort ()
+	{
+		return (this.port);
+	}
+	
+	public final String getRoutingKeyPattern ()
+	{
+		return (this.routingKeyLayout.getPattern ());
+	}
+	
+	public final Serializer getSerializer ()
+	{
+		return (this.serializer);
+	}
+	
+	public final String getUsername ()
+	{
+		return (this.username);
+	}
+	
+	public final String getVirtualHost ()
+	{
+		return (this.virtualHost);
+	}
+	
 	public final boolean isDrained ()
 	{
 		return (this.buffer.isEmpty ());
@@ -99,6 +139,13 @@ public final void setRoutingKeyPattern (final String pattern)
 		this.routingKeyLayout.setPattern (pattern);
 	}
 
+	public final void setSerializer (final Serializer serializer)
+	{
+		if (this.isStarted ())
+			throw (new IllegalStateException ("amqp appender is already started"));
+		this.serializer = serializer;
+	}
+	
 	public final void setUsername (final String username)
 	{
 		if (this.isStarted ())
@@ -127,6 +174,7 @@ public final void start ()
 						new DefaultContextAwareCallbacks (this), this.buffer);
 		this.publisher.start ();
 		super.start ();
+		this.started ();
 	}
 
 	public final void stop ()
@@ -137,6 +185,7 @@ public final void stop ()
 		this.routingKeyLayout.stop ();
 		this.publisher.stop ();
 		super.stop ();
+		this.stopped ();
 	}
 
 	protected final void append (final ILoggingEvent originalEvent)
@@ -160,6 +209,12 @@ protected final void append (final ILoggingEvent originalEvent)
 		}
 	}
 
+	protected void started ()
+	{}
+	
+	protected void stopped ()
+	{}
+	
 	private final PubLoggingEventVO prepare (final ILoggingEvent originalEvent)
 	{
 		final PubLoggingEventVO newEvent = PubLoggingEventVO.build (originalEvent);
@@ -176,7 +231,7 @@ private final PubLoggingEventVO prepare (final ILoggingEvent originalEvent)
 	private Integer port;
 	private AmqpPublisher publisher;
 	private final PatternLayout routingKeyLayout;
-	private final Serializer serializer;
+	private Serializer serializer;
 	private String username;
 	private String virtualHost;
 

logback-amqp-appender/src/main/java/ch/qos/logback/amqp/tools/DefaultBinarySerializer.java

@@ -9,11 +9,11 @@
 import java.io.Serializable;
 
 
-public final class DefaultBinarySerializer
+public class DefaultBinarySerializer
 		implements
 			Serializer
 {
-	public final Serializable deserialize (final byte[] data)
+	public Serializable deserialize (final byte[] data)
 			throws Throwable
 	{
 		final ByteArrayInputStream stream = new ByteArrayInputStream (data);
@@ -22,17 +22,22 @@ public final Serializable deserialize (final byte[] data)
 		return (object);
 	}
 
-	public final String getContentEncoding ()
+	public String getContentEncoding ()
 	{
 		return (this.contentEncoding);
 	}
 
-	public final String getContentType ()
+	public String getContentType ()
 	{
 		return (this.contentType);
 	}
 
-	public final byte[] serialize (final Serializable object)
+	public int getDefaultBufferSize ()
+	{
+		return (this.defaultBufferSize);
+	}
+	
+	public byte[] serialize (final Serializable object)
 			throws Throwable
 	{
 		final ByteArrayOutputStream stream = new ByteArrayOutputStream (this.defaultBufferSize);
@@ -42,7 +47,22 @@ public final byte[] serialize (final Serializable object)
 		return (stream.toByteArray ());
 	}
 
-	public final String contentEncoding = "binary";
-	public final String contentType = "application/x-java-serialized-object";
-	public final int defaultBufferSize = 2048;
+	public void setContentEncoding (final String contentEncoding)
+	{
+		this.contentEncoding = contentEncoding;
+	}
+	
+	public void setContentType (final String contentType)
+	{
+		this.contentType = contentType;
+	}
+	
+	public void setDefaultBufferSize (final int defaultBufferSize)
+	{
+		this.defaultBufferSize = defaultBufferSize;
+	}
+	
+	protected String contentEncoding = "binary";
+	protected String contentType = "application/x-java-serialized-object";
+	protected int defaultBufferSize = 2048;
 }

logback-amqp-appender/src/main/java/ch/qos/logback/amqp/tools/DefaultContextAwareCallbacks.java

@@ -6,7 +6,7 @@
 import ch.qos.logback.core.spi.ContextAware;
 
 
-public final class DefaultContextAwareCallbacks
+public class DefaultContextAwareCallbacks
 		implements
 			Callbacks
 {
@@ -16,13 +16,12 @@ public DefaultContextAwareCallbacks (final ContextAware delegate)
 		this.delegate = delegate;
 	}
 
-	public final void handleException (
-			final Throwable exception, final String messageFormat, final Object ... messageArguments)
+	public void handleException (final Throwable exception, final String messageFormat, final Object ... messageArguments)
 	{
 		this.handleLogEvent (Level.ERROR, exception, messageFormat, messageArguments);
 	}
 
-	public final void handleLogEvent (
+	public void handleLogEvent (
 			final Level level, final Throwable exception, final String messageFormat, final Object ... messageArguments)
 	{
 		final String message = String.format (messageFormat, messageArguments);
@@ -54,5 +53,5 @@ public final void handleLogEvent (
 		}
 	}
 
-	private final ContextAware delegate;
+	protected ContextAware delegate;
 }

logback-amqp-appender/src/main/java/ch/qos/logback/amqp/tools/DefaultMutator.java

@@ -81,7 +81,7 @@ public void setNode (final String node)
 	protected String application;
 	protected String component;
 	protected String node;
-	private long sequence;
+	protected long sequence;
 
 	public static final String applicationKey = "application";
 	public static final String componentKey = "component";