So many bugs...

Author: Tim Sharpe

lib/puppet/provider/ha_crm_parameter/crm.rb

@@ -1,31 +1,31 @@
 require 'rexml/document'
 
-Puppet::Type.type(:ha_crm_property).provide(:crm) do
+Puppet::Type.type(:ha_crm_parameter).provide(:crm) do
 
 	commands :crm_resource => "crm_resource"
 
 	def create
-		if resource[:meta]
+		if resource[:meta] == :true
 			crm_resource "-m", "-r", resource[:resource], "-p", resource[:name], "-v", resource[:value]
 		else
 			crm_resource "-r", resource[:resource], "-p", resource[:name], "-v", resource[:value]
 		end
 	end
 
 	def destroy
-		if resource[:meta]
+		if resource[:meta] == :true
 			crm_resource "-m", "-r", resource[:resource], "-d", resource[:name]
 		else
 			crm_resource "-r", resource[:resource], "-d", resource[:name]
 		end
 	end
 
 	def exists?
-		if resource[:only_run_on_dc] and Facter.value(:ha_cluster_dc) != Facter.value(:fqdn)
-			resource[:value]
+		if resource[:only_run_on_dc] and (Facter.value(:ha_cluster_dc) != Facter.value(:fqdn))
+			true
 		else
 			cib = REXML::Document.new File.open("/var/lib/heartbeat/crm/cib.xml")
-			if resource[:meta]
+			if resource[:meta] == :true
 				type = "meta"
 			else
 				type = "instance"
@@ -35,9 +35,13 @@ def exists?
 			nvpair = REXML::XPath.first(cib, "//master[@id='#{resource[:resource]}']/#{type}_attributes/nvpair[@name='#{resource[:name]}']") if nvpair.nil?
 			nvpair = REXML::XPath.first(cib, "//clone[@id='#{resource[:resource]}']/#{type}_attributes/nvpair[@name='#{resource[:name]}']") if nvpair.nil?
 			if nvpair.nil?
-				:absent
+				false
 			else
-				nvpair.attribute(:value).value
+        if nvpair.attribute(:value).value == resource[:value]
+				  true
+        else
+          false
+        end
 			end
 		end
 	end

lib/puppet/type/ha_crm_parameter.rb

@@ -20,10 +20,17 @@
 		desc "The value of the parameter"
 	end
 
-	newparam(:meta, :boolean => true) do
+	newparam(:meta) do
 		desc "Should this parameter be a meta-parameter?"
 
 		newvalues(:true, :false)
 		defaultto :false
 	end
+
+  newparam(:only_run_on_dc) do
+    desc "Should this resource only be actioned if the node is the cluster DC?"
+
+    newvalues(:true, :false)
+    defaultto :true
+  end
 end