OnlineChecks: Fix copyright headers, Update VirusTotal dialog text.

Author: dmex

plugins/OnlineChecks/page1.c

@@ -1,6 +1,6 @@
 /*
  * Process Hacker Plugins -
- *   Update Checker Plugin
+ *   Online Checks Plugin
  *
  * Copyright (C) 2016 dmex
  *
@@ -75,4 +75,4 @@ VOID ShowVirusTotalUploadDialog(
     config.lpCallbackData = (LONG_PTR)Context;
 
     SendMessage(Context->DialogHandle, TDM_NAVIGATE_PAGE, 0, (LPARAM)&config);
-}
+}

plugins/OnlineChecks/page2.c

@@ -1,6 +1,6 @@
 /*
  * Process Hacker Plugins -
- *   Update Checker Plugin
+ *   Online Checks Plugin
  *
  * Copyright (C) 2016 dmex
  *
@@ -24,12 +24,12 @@
 
 static TASKDIALOG_BUTTON TaskDialogButtonArray[] =
 {
-    { IDOK, L"Upload file" },
-    { IDRETRY, L"Reanalyse file" },
-    { IDYES, L"View last analysis" },
+    { IDOK, L"Upload file\nUpload fresh sample to VirusTotal for analysis" },
+    { IDRETRY, L"Reanalyse file\nRescan the existing sample on VirusTotal" },
+    { IDYES, L"View last analysis\nOpen the last VirusTotal analysis page" },
 };
 
-HRESULT CALLBACK ShowAvailableCallbackProc(
+HRESULT CALLBACK TaskDialogResultFoundProc(
     _In_ HWND hwndDlg,
     _In_ UINT uMsg,
     _In_ WPARAM wParam,
@@ -87,7 +87,7 @@ VOID ShowFileFoundDialog(
 
     if (Context->FileExists)
     {    
-        //was last analysed by VirusTotal on 2016-12-28 05:26:50 UTC (1 hour ago) it was first analysed by VirusTotal on 2016-12-12 17:08:19 UTC.
+        // was last analysed by VirusTotal on 2016-12-28 05:26:50 UTC (1 hour ago) it was first analysed by VirusTotal on 2016-12-12 17:08:19 UTC.
         config.pszMainInstruction = PhaFormatString(
             L"%s was last analysed %s ago", 
             PhGetStringOrEmpty(Context->BaseFileName), 
@@ -113,9 +113,8 @@ VOID ShowFileFoundDialog(
     config.cxWidth = 200;
     config.pButtons = TaskDialogButtonArray;
     config.cButtons = ARRAYSIZE(TaskDialogButtonArray);
-
     config.lpCallbackData = (LONG_PTR)Context;
-    config.pfCallback = ShowAvailableCallbackProc;
+    config.pfCallback = TaskDialogResultFoundProc;
 
     SendMessage(Context->DialogHandle, TDM_NAVIGATE_PAGE, 0, (LPARAM)&config);
-}
+}

plugins/OnlineChecks/page3.c

@@ -1,6 +1,6 @@
 /*
  * Process Hacker Plugins -
- *   Update Checker Plugin
+ *   Online Checks Plugin
  *
  * Copyright (C) 2016 dmex
  *
@@ -96,4 +96,4 @@ VOID ShowVirusTotalProgressDialog(
     config.pfCallback = ShowProgressCallbackProc;
 
     SendMessage(Context->DialogHandle, TDM_NAVIGATE_PAGE, 0, (LPARAM)&config);
-}
+}

plugins/OnlineChecks/page4.c

@@ -1,6 +1,6 @@
 /*
  * Process Hacker Plugins -
- *   Update Checker Plugin
+ *   Online Checks Plugin
  *
  * Copyright (C) 2016 dmex
  *
@@ -78,4 +78,4 @@ VOID VirusTotalShowErrorDialog(
     config.pfCallback = TaskDialogErrorProc;
 
     SendMessage(Context->DialogHandle, TDM_NAVIGATE_PAGE, 0, (LPARAM)&config);
-}
+}

plugins/OnlineChecks/upload.c

@@ -1,8 +1,8 @@
 /*
  * Process Hacker Plugins -
- *   Update Checker Plugin
+ *   Online Checks Plugin
  *
- * Copyright (C) 2011-2016 dmex
+ * Copyright (C) 2016 dmex
  *
  * This file is part of Process Hacker.
  *
@@ -159,28 +159,6 @@ VOID TaskDialogCreateIcons(
     SendMessage(Context->DialogHandle, WM_SETICON, ICON_BIG, (LPARAM)Context->IconLargeHandle);
 }
 
-VOID TaskDialogLinkClicked(
-    _In_ PUPLOAD_CONTEXT Context
-    )
-{
-    //if (!PhIsNullOrEmptyString(Context->ReleaseNotesUrl))
-    //{
-    //    PhShellExecute(Context->DialogHandle, PhGetStringOrEmpty(Context->ReleaseNotesUrl), NULL);
-    //}
-}
-
-PPH_STRING UpdaterGetOpaqueXmlNodeText(
-    _In_ mxml_node_t *xmlNode
-)
-{
-    if (xmlNode && xmlNode->child && xmlNode->child->type == MXML_OPAQUE && xmlNode->child->value.opaque)
-    {
-        return PhConvertUtf8ToUtf16(xmlNode->child->value.opaque);
-    }
-
-    return PhReferenceEmptyString();
-}
-
 PPH_STRING UpdateVersionString(
     VOID
     )
@@ -409,7 +387,6 @@ NTSTATUS UploadFileThreadStart(
     PH_STRING_BUILDER httpPostHeader = { 0 };
     PH_STRING_BUILDER httpPostFooter = { 0 };
     PUPLOAD_CONTEXT context = (PUPLOAD_CONTEXT)Parameter;
-    BYTE buffer[PAGE_SIZE];
 
     serviceInfo = GetUploadServiceInfo(context->Service);
 
@@ -643,6 +620,8 @@ NTSTATUS UploadFileThreadStart(
 
     while (TRUE)
     {
+        BYTE buffer[PAGE_SIZE];
+
         if (!context->UploadThreadHandle)
             goto CleanupExit;
 
@@ -1182,9 +1161,6 @@ HRESULT CALLBACK TaskDialogBootstrapCallback(
             // Create the Taskdialog icons
             TaskDialogCreateIcons(context);
 
-            // Subclass the Taskdialog
-            SetWindowSubclass(hwndDlg, TaskDialogSubclassProc, 0, (ULONG_PTR)context);
-
             if (SUCCEEDED(CoCreateInstance(&CLSID_TaskbarList, NULL, CLSCTX_INPROC_SERVER, &IID_ITaskbarList3, &context->TaskbarListClass)))
             {
                 if (!SUCCEEDED(ITaskbarList3_HrInit(context->TaskbarListClass)))
@@ -1194,6 +1170,9 @@ HRESULT CALLBACK TaskDialogBootstrapCallback(
                 }
             }
 
+            // Subclass the Taskdialog
+            SetWindowSubclass(hwndDlg, TaskDialogSubclassProc, 0, (ULONG_PTR)context);
+
             ShowVirusTotalUploadDialog(context);
         }
         break;

plugins/OnlineChecks/virustotal.c

@@ -1,6 +1,6 @@
 /*
  * Process Hacker Online Checks -
- *   database functions
+ *   VirusTotal functions
  *
  * Copyright (C) 2016 dmex
  *