Skip to content

Commit 64bed98

Browse files
Dmitrii AbramovFacebook Github Bot 9
authored andcommitted
jest-jasmine1 && jest-jasmine2
Summary:(added by cpojer): bypass-lint vendored files don't conform to our eslint standard Closes jestjs#816 Differential Revision: D3096143 fb-gh-sync-id: 96e46ea39b13a2d4688d7e4f70382e00ac5784c9 fbshipit-source-id: 96e46ea39b13a2d4688d7e4f70382e00ac5784c9
1 parent 35ac3cc commit 64bed98

File tree

20 files changed

+69
-35
lines changed

20 files changed

+69
-35
lines changed

.eslintignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
bin/
22
docs/
33
**/node_modules/**
4-
vendor/
4+
**/vendor/**
55
website/

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
"diff": "^2.1.1",
1010
"graceful-fs": "^4.1.3",
1111
"istanbul": "^0.4.2",
12+
"jest-jasmine1": "^9.0.3",
13+
"jest-jasmine2": "^9.0.3",
1214
"jest-mock": "^9.0.3",
1315
"jest-util": "^9.0.3",
1416
"jsdom": "^7.2.0",

packages/jest-jasmine1/package.json

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"name": "jest-jasmine1",
3+
"version": "9.0.3",
4+
"repository": {
5+
"type": "git",
6+
"url": "https://github.com/facebook/jest.git"
7+
},
8+
"license": "BSD-3-Clause",
9+
"main": "src/index.js",
10+
"dependencies": {
11+
"graceful-fs": "^4.1.3",
12+
"jest-util": "^9.0.3"
13+
},
14+
"scripts": {
15+
"test": "../../bin/jest.js"
16+
},
17+
"jest": {
18+
"testEnvironment": "<rootDir>/../../src/environments/NodeEnvironment"
19+
}
20+
}

src/testRunners/jasmine/__tests__/JasmineReporter-test.js renamed to packages/jest-jasmine1/src/__tests__/reporter-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ describe('JasmineReporter', function() {
2020
var reporter;
2121

2222
beforeEach(function() {
23-
JasmineReporter = require('../JasmineReporter');
23+
JasmineReporter = require('../reporter');
2424
chalk = require('chalk');
2525

2626
reporter = new JasmineReporter();

src/testRunners/jasmine/jasmine1.js renamed to packages/jest-jasmine1/src/index.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,14 @@
77
*/
88
'use strict';
99

10-
const VENDOR_PATH = '../../../vendor/';
11-
const JASMINE_PATH = require.resolve(VENDOR_PATH + '/jasmine/jasmine-1.3.0');
12-
const JASMINE_ONLY_PATH =
13-
require.resolve(VENDOR_PATH + '/jasmine-only/jasmine-only.js');
14-
1510
const fs = require('graceful-fs');
16-
const jasminePit = require(VENDOR_PATH + '/jasmine-pit/jasmine-pit');
17-
const JasmineReporter = require('./JasmineReporter');
11+
const jasminePit = require('jest-util/lib/jasmine-pit');
12+
const JasmineReporter = require('./reporter');
1813
const path = require('path');
1914

15+
const JASMINE_PATH = require.resolve('../vendor/jasmine-1.3.0');
16+
const JASMINE_ONLY_PATH = require.resolve('./jasmine-only.js');
17+
2018
const jasmineFileContent = fs.readFileSync(JASMINE_PATH, 'utf8');
2119
const jasmineOnlyContent = fs.readFileSync(JASMINE_ONLY_PATH, 'utf8');
2220

vendor/jasmine-only/jasmine-only.js renamed to packages/jest-jasmine1/src/jasmine-only.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
* https://github.com/davemo/jasmine-only
44
*/
55
(function() {
6-
var __hasProp = {}.hasOwnProperty,
7-
__extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; };
8-
6+
var __hasProp = {}.hasOwnProperty;
7+
var __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; }; // eslint-disable-line
98
(function(jasmine) {
109
var describeOnly, env, itOnly, root;
1110
root = (1, eval)('this');
@@ -47,7 +46,7 @@
4746
declarationError = e;
4847
}
4948
if (declarationError) {
50-
this.it("encountered a declaration exception", function() {
49+
this.it('encountered a declaration exception', function() {
5150
throw declarationError;
5251
});
5352
}

src/testRunners/jasmine/JasmineReporter.js renamed to packages/jest-jasmine1/src/reporter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
*/
88
'use strict';
99

10-
const jasmine = require('../../../vendor/jasmine/jasmine-1.3.0').jasmine;
11-
const JasmineFormatter = require('./JasmineFormatter');
10+
const jasmine = require('../vendor/jasmine-1.3.0').jasmine;
11+
const JasmineFormatter = require('jest-util/lib/JasmineFormatter');
1212

1313
class JasmineReporter extends jasmine.Reporter {
1414

packages/jest-jasmine2/package.json

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"name": "jest-jasmine2",
3+
"version": "9.0.3",
4+
"repository": {
5+
"type": "git",
6+
"url": "https://github.com/facebook/jest.git"
7+
},
8+
"license": "BSD-3-Clause",
9+
"main": "src/index.js",
10+
"dependencies": {
11+
"graceful-fs": "^4.1.3",
12+
"jest-util": "^9.0.3"
13+
},
14+
"scripts": {
15+
"test": "../../bin/jest.js"
16+
},
17+
"jest": {
18+
"testEnvironment": "<rootDir>/../../src/environments/NodeEnvironment"
19+
}
20+
}

src/testRunners/jasmine/__tests__/Jasmine2Reporter-test.js renamed to packages/jest-jasmine2/src/__tests__/reporter-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe('Jasmine2Reporter', function() {
1717
var reporter;
1818

1919
beforeEach(function() {
20-
JasmineReporter = require('../Jasmine2Reporter');
20+
JasmineReporter = require('../reporter');
2121
chalk = require('chalk');
2222

2323
reporter = new JasmineReporter();

src/testRunners/jasmine/jasmine2.js renamed to packages/jest-jasmine2/src/index.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,12 @@
77
*/
88
'use strict';
99

10-
const VENDOR_PATH = '../../../vendor/';
11-
const JASMINE_PATH = require.resolve(VENDOR_PATH + '/jasmine/jasmine-2.3.4.js');
12-
1310
const fs = require('graceful-fs');
14-
const jasminePit = require(VENDOR_PATH + '/jasmine-pit/jasmine-pit');
15-
const JasmineReporter = require('./Jasmine2Reporter');
11+
const jasminePit = require('jest-util/lib/jasmine-pit');
12+
const JasmineReporter = require('./reporter');
1613
const path = require('path');
1714

15+
const JASMINE_PATH = require.resolve('../vendor/jasmine-2.3.4.js');
1816
const jasmineFileContent =
1917
fs.readFileSync(require.resolve(JASMINE_PATH), 'utf8');
2018

src/testRunners/jasmine/Jasmine2Reporter.js renamed to packages/jest-jasmine2/src/reporter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
*/
88
'use strict';
99

10-
const jasmineRequire = require('../../../vendor/jasmine/jasmine-2.3.4.js');
10+
const jasmineRequire = require('../vendor/jasmine-2.3.4.js');
1111
const jasmine = jasmineRequire.core(jasmineRequire);
12-
const JasmineFormatter = require('./JasmineFormatter');
12+
const JasmineFormatter = require('jest-util/lib/JasmineFormatter');
1313

1414
class Jasmine2Reporter {
1515

src/testRunners/jasmine/JasmineFormatter.js renamed to packages/jest-util/lib/JasmineFormatter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
const diff = require('diff');
1212
const chalk = require('chalk');
13-
const utils = require('jest-util');
13+
const utils = require('../index');
1414

1515
const ERROR_TITLE_COLOR = chalk.bold.underline.red;
1616
const DIFFABLE_MATCHERS = Object.assign(Object.create(null), {

src/testRunners/jasmine/__tests__/JasmineFormatter-test.js renamed to packages/jest-util/lib/__tests__/JasmineFormatter-test.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,8 @@
1111

1212
jest.disableAutomock();
1313

14-
const path = require('path');
15-
const VENDOR_PATH = path.resolve(__dirname, '../../../../vendor');
16-
17-
const jasmine = require(`${VENDOR_PATH}/jasmine/jasmine-1.3.0`).jasmine;
18-
const jasmine2Require = require(`${VENDOR_PATH}/jasmine/jasmine-2.3.4.js`);
14+
const jasmine = require('jest-jasmine1/vendor/jasmine-1.3.0').jasmine;
15+
const jasmine2Require = require('jest-jasmine2/vendor/jasmine-2.3.4.js');
1916
const jasmine2 = jasmine2Require.core(jasmine2Require);
2017

2118
const JasmineFormatter = require('../JasmineFormatter');

src/testRunners/jasmine/__tests__/customMatchers-test.js renamed to src/__tests__/customMatchers-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
jest.disableAutomock();
1313

14-
const formatter = new (require('../JasmineFormatter'))(jasmine);
14+
const formatter = new (require('jest-util/lib/JasmineFormatter'))(jasmine);
1515
const CALLED_AT_LEAST_ONCE = 'Expected to be called at least once';
1616
const SHOULD_NOT_BE_CALLED = 'Expected not to be called';
1717
const NOT_EXPECTED_VALUES = (

src/config/normalize.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ function normalize(config, argv) {
7777
}
7878

7979
if (config.testRunner === 'jasmine1') {
80-
config.testRunner = require.resolve('../testRunners/jasmine/jasmine1');
80+
config.testRunner = require.resolve('jest-jasmine1');
8181
} else if (!config.testRunner || config.testRunner === 'jasmine2') {
82-
config.testRunner = require.resolve('../testRunners/jasmine/jasmine2');
82+
config.testRunner = require.resolve('jest-jasmine2');
8383
} else {
8484
try {
8585
config.testRunner = path.resolve(

src/lib/__tests__/utils-normalizeConfig-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ describe('utils-normalizeConfig', () => {
371371
rootDir: '/root/path/foo',
372372
});
373373

374-
expect(config.testRunner.endsWith('jasmine2.js')).toBe(true);
374+
expect(config.testRunner).toMatch('jasmine2');
375375
});
376376

377377
it('can be changed to jasmine1', () => {
@@ -380,7 +380,7 @@ describe('utils-normalizeConfig', () => {
380380
testRunner: 'jasmine1',
381381
});
382382

383-
expect(config.testRunner.endsWith('jasmine1.js')).toBe(true);
383+
expect(config.testRunner).toMatch('jasmine1');
384384
});
385385

386386
it('is overwritten by argv', () => {
@@ -393,7 +393,7 @@ describe('utils-normalizeConfig', () => {
393393
}
394394
);
395395

396-
expect(config.testRunner.endsWith('jasmine1.js')).toBe(true);
396+
expect(config.testRunner).toMatch('jasmine1');
397397
});
398398
});
399399

0 commit comments

Comments
 (0)