Skip to content

Commit c915acc

Browse files
authored
Merge branch 'master' into patch-1
2 parents 1c2e4d1 + 9e1ef7f commit c915acc

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,21 @@
3434
"chai": "4.2.0",
3535
"conditional-type-checks": "1.0.5",
3636
"husky": "4.2.5",
37-
"karma": "5.0.2",
37+
"karma": "^5.0.9",
3838
"karma-chai": "0.1.0",
3939
"karma-chrome-launcher": "3.1.0",
4040
"karma-detect-browsers": "2.3.3",
4141
"karma-firefox-launcher": "1.3.0",
42-
"karma-mocha": "2.0.0",
42+
"karma-mocha": "^2.0.1",
4343
"karma-safari-launcher": "1.0.0",
4444
"karma-safaritechpreview-launcher": "2.0.2",
45-
"mocha": "7.1.2",
45+
"mocha": "^7.2.0",
4646
"prettier": "2.0.5",
4747
"rimraf": "3.0.2",
48-
"rollup": "2.7.3",
49-
"rollup-plugin-terser": "5.3.0",
50-
"rollup-plugin-typescript2": "0.27.0",
51-
"typescript": "3.8.3"
48+
"rollup": "^2.11.2",
49+
"rollup-plugin-terser": "^6.1.0",
50+
"rollup-plugin-typescript2": "^0.27.1",
51+
"typescript": "^3.9.3"
5252
},
5353
"dependencies": {}
5454
}

rollup.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ function config({ format, minify, input, ext = "js" }) {
2727
}),
2828
minify
2929
? terser({
30-
sourcemap: true,
3130
compress: true,
3231
mangle: true,
3332
})

tests/type-checks.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,10 @@ async function closureSoICanUseAwait() {
155155
assert<Has<typeof r3, Promise<number>>>(true);
156156

157157
// @ts-expect-error
158-
// proxy.proxyProp.method(123);
158+
proxy.proxyProp.method(123);
159159

160160
// @ts-expect-error
161-
// proxy.proxyProp.method();
161+
proxy.proxyProp.method();
162162

163163
const r4 = proxy.methodWithProxiedReturnValue();
164164
assert<IsAny<typeof r4>>(false);
@@ -188,10 +188,10 @@ async function closureSoICanUseAwait() {
188188
inst1[Comlink.createEndpoint]();
189189

190190
// @ts-expect-error
191-
// await new ProxiedFooClass(123);
191+
await new ProxiedFooClass(123);
192192

193193
// @ts-expect-error
194-
// await new ProxiedFooClass();
194+
await new ProxiedFooClass();
195195

196196
//
197197
// Tests for advanced proxy use cases
@@ -302,12 +302,12 @@ async function closureSoICanUseAwait() {
302302
>(true);
303303

304304
// @ts-expect-error
305-
// subscriber.next();
305+
subscriber.next();
306306

307307
if (subscriber.next) {
308308
// Only checking for presence is not enough, since it could be a Promise
309309
// @ts-expect-error
310-
// subscriber.next();
310+
subscriber.next();
311311
}
312312

313313
if (typeof subscriber.next === "function") {
@@ -324,7 +324,7 @@ async function closureSoICanUseAwait() {
324324
proxy2.registerProvider(
325325
// Async callback
326326
Comlink.proxy(async ({ textDocument }: Params) => {
327-
return Comlink.proxy({
327+
const subscribable = Comlink.proxy({
328328
subscribe(
329329
subscriber: Comlink.Remote<Subscriber<string> & Comlink.ProxyMarked>
330330
): Unsubscribable & Comlink.ProxyMarked {
@@ -345,6 +345,7 @@ async function closureSoICanUseAwait() {
345345
return Comlink.proxy({ unsubscribe() {} });
346346
},
347347
});
348+
return subscribable;
348349
})
349350
);
350351
}

0 commit comments

Comments
 (0)