fix swoole#4282

Author: matyhtf

ext-src/swoole_process_pool.cc

@@ -334,10 +334,7 @@ static PHP_METHOD(swoole_process_pool, __construct) {
         pool->main_loop = nullptr;
     } else {
         if (ipc_type > 0) {
-            if (pool->set_protocol(0, SW_INPUT_BUFFER_SIZE) < 0) {
-                zend_throw_exception_ex(swoole_exception_ce, errno, "failed to create process pool");
-                RETURN_FALSE;
-            }
+            pool->set_protocol(0, SW_INPUT_BUFFER_SIZE);
         }
     }
 
@@ -360,9 +357,18 @@ static PHP_METHOD(swoole_process_pool, set) {
 
     ProcessPoolProperty *pp = php_swoole_process_pool_get_and_check_pp(ZEND_THIS);
 
+    php_swoole_set_global_option(vht);
+    php_swoole_set_coroutine_option(vht);
+    php_swoole_set_aio_option(vht);
+
     if (php_swoole_array_get_value(vht, "enable_coroutine", ztmp)) {
         pp->enable_coroutine = zval_is_true(ztmp);
     }
+
+    ProcessPool *pool = php_swoole_process_pool_get_and_check_pool(ZEND_THIS);
+    if (pp->enable_coroutine) {
+        pool->main_loop = nullptr;
+    }
 }
 
 static PHP_METHOD(swoole_process_pool, on) {

include/swoole_process_pool.h

@@ -261,7 +261,7 @@ struct ProcessPool {
 
     void set_max_request(uint32_t _max_request, uint32_t _max_request_grace);
     int get_max_request();
-    int set_protocol(int task_protocol, uint32_t max_packet_size);
+    void set_protocol(int task_protocol, uint32_t max_packet_size);
     bool detach();
     int wait();
     int start();

src/os/process_pool.cc

@@ -497,7 +497,7 @@ static int ProcessPool_worker_loop(ProcessPool *pool, Worker *worker) {
     return SW_OK;
 }
 
-int ProcessPool::set_protocol(int task_protocol, uint32_t max_packet_size) {
+void ProcessPool::set_protocol(int task_protocol, uint32_t max_packet_size) {
     if (task_protocol) {
         main_loop = ProcessPool_worker_loop;
     } else {
@@ -508,8 +508,6 @@ int ProcessPool::set_protocol(int task_protocol, uint32_t max_packet_size) {
         max_packet_size_ = max_packet_size;
         main_loop = ProcessPool_worker_loop_ex;
     }
-
-    return SW_OK;
 }
 
 static int ProcessPool_worker_loop_ex(ProcessPool *pool, Worker *worker) {