Merge pull request phpbridge#36 from dshafik/remove-title-titles

Remove title attributes from steps

Author: michellesanver

lib/step.rb

@@ -89,7 +89,7 @@ def step name = nil, options = {}
     num = next_step_number
     a(:name => "step#{current_anchor_num}")
     a(:name => options[:anchor_name]) if options[:anchor_name]
-    div :class => "step", :title => name do
+    div :class => "step" do
       h1 do
         widget BigCheckbox
         prefix "Step #{num}" + (!name.nil? ? ': ' : '')

spec/step_page_spec.rb

@@ -29,7 +29,7 @@
         <h1 class="doc_title">Hello</h1>
         <div class="doc">
           <a name="step1"></a>
-          <div class="step" title="hello">
+          <div class="step">
             <h1>#{checkbox_html}<span class="prefix">Step 1: </span>hello</h1>
           </div>
         </div>

spec/step_spec.rb

@@ -28,19 +28,13 @@ def step_obj_for(path)
     html = to_html(steps.first)
     checkbox_html = %q{<input class="big_checkbox" id="big_checkbox_1" name="big_checkbox_1" type="checkbox" value="valuable"><label for="big_checkbox_1"></label>}
     expected = <<-HTML.strip_heredoc.gsub("\n", '')
-      <div class="step" title="hello">
+      <div class="step">
       <h1>#{checkbox_html}<span class="prefix">Step 1: </span>hello</h1>
       </div>
     HTML
     assert { html == expected }
   end
 
-  it "puts titles in based on step names" do
-    steps = html_doc.css(".step")
-    assert { steps.first["title"] == "hello" }
-    assert { steps[1]["title"] == "goodbye" }
-  end
-
   it "puts anchors in based on step numbers" do
     steps = html_doc.css(".step")
     steps.each_with_index do |step, i|
@@ -71,8 +65,9 @@ def step_obj_for(path)
       end
     RUBY
 
-    titles = html_doc.css('.step').map{|div| div["title"]}
-    assert { titles == ["breakfast", "cereal", "eggs", "lunch", "salad", "sandwich"] }
+    titles = html_doc.css('.step h1').map{|title| title.text}
+    titles.inspect
+    assert { titles == ["Step 1: breakfast", "Step 1.1: cereal", "Step 1.2: eggs", "Step 2: lunch", "Step 2.1: salad", "Step 2.2: sandwich"] }
 
     anchors = html_doc.css("a")
     names = anchors.map{|a| a["name"]}
@@ -90,7 +85,7 @@ def step_obj_for(path)
           step "sandwich"
         end
       RUBY
-      a = html_doc.css(".step[title=breakfast] a.link").first
+      a = html_doc.css(".step").first.css("a.link").first
       hash = URI.escape '#'
       assert { a["href"] == "choose_breakfast?back=hello#{hash}step1" }
     end