Fix readInstalled regression from last asyncMap changes.

Author: isaacs

lib/utils/read-installed.js

@@ -20,11 +20,14 @@ function readInstalled (args, cb) {
     packages = packages.filter(function (dir) {
       return (showAll || args.indexOf(dir) !== -1) && dir.charAt(0) !== "."
     })
-    asyncMap(packages, function (package, cb) {
-      data[package] = data[package] || {}
-      var packageDir = path.join(npm.dir, package)
-        , active = path.join(packageDir, "active")
+    var pkgDirs = {}
+    packages.forEach(function (p) {
+      pkgDirs[p] = path.join(npm.dir, p)
+      data[p] = {}
+    })
 
+    asyncMap(packages, function (package, cb) {
+      var active = path.join(pkgDirs[package], "active")
       fs.lstat(active, function (er, s) {
         if (er || !s.isSymbolicLink()) return cb()
         fs.readlink(active, function (er, p) {
@@ -35,18 +38,22 @@ function readInstalled (args, cb) {
           return cb()
         })
       })
-
-      fs.readdir(packageDir, function (er, versions) {
-        if (er) return cb() // skip over non-dirs or missing things.
+    }, function (package, cb) {
+      fs.readdir(pkgDirs[package], function (er, versions) {
+        if (er) {
+          delete data[package]
+          return cb() // skip over non-dirs or missing things.
+        }
         asyncMap(versions, function (version, cb) {
-          if (!version) return cb()
           if (semver.valid(version)) {
             data[package][version] = data[package][version] || {}
           }
+          cb()
         }, cb)
       })
-
-    // just return the data object we've created.
-    }, function (er) { cb(er, data) })
+    }, function (er) {
+      // just return the data object we've created.
+      cb(er, data)
+    })
   })
 }