You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Require whitespace before as in to/downto labels (#1085)
* Require whitespace before `as` in `to`/`downto` labels
The `RE_TO_DOWNTO_AS_LABELS` rule previously used `\s*` between `(to|downto)` and `(as)`,
allowing zero spaces and accidentally matching identifiers like "toast".
Change the pattern to `\s+` so that an actual space is required, preventing spurious `as`
highlighting inside identifiers.
* Prefix `RE_TO_DOWNTO_AS_LABELS` patterns with `~` to ensure they only apply to labelled arguments
* Add CHANGELOG entry
Copy file name to clipboardExpand all lines: CHANGELOG.md
+2
Original file line number
Diff line number
Diff line change
@@ -14,6 +14,8 @@
14
14
15
15
#### :bug: Bug fix
16
16
17
+
- Fix: incorrect highlighting of `as` inside labelled arguments like `toast`https://github.com/rescript-lang/rescript-vscode/pull/1085
18
+
17
19
- Fix: bug where incremental analysis does not work when the project folder contains a dot. https://github.com/rescript-lang/rescript-vscode/pull/1080
18
20
19
21
- Fix: bug where incremental compilation crashes when rewatch is being run in a specific package vs the root of the monorepo. https://github.com/rescript-lang/rescript-vscode/pull/1082
0 commit comments