comments

Author: Stephane Landelle

providers/netty/src/main/java/org/asynchttpclient/providers/netty/channel/ChannelManager.java

@@ -418,7 +418,7 @@ public void upgradePipelineForWebSockets(ChannelPipeline pipeline) {
     public final Callback newDrainCallback(final NettyResponseFuture<?> future, final Channel channel, final boolean keepAlive, final String poolKey) {
 
         return new Callback(future) {
-            public void call() throws Exception {
+            public void call() {
                 tryToOfferChannelToPool(channel, keepAlive, poolKey);
             }
         };

providers/netty/src/main/java/org/asynchttpclient/providers/netty/handler/HttpProtocol.java

@@ -229,7 +229,7 @@ private boolean exitAfterHandling401(//
 
                 logger.debug("Sending authentication to {}", request.getUri());
                 Callback callback = new Callback(future) {
-                    public void call() throws Exception {
+                    public void call() throws IOException {
                         channelManager.drainChannel(channel, future);
                         requestSender.sendNextRequest(nextRequest, future);
                     }
@@ -240,6 +240,7 @@ public void call() throws Exception {
                     // before executing the next request.
                     Channels.setAttribute(channel, callback);
                 else
+                    // call might crash with an IOException
                     callback.call();
 
                 return true;
@@ -451,6 +452,7 @@ public void handle(final Channel channel, final NettyResponseFuture<?> future, f
                     finishUpdate(future, channel, !last);
             }
         } catch (Exception t) {
+            // e.g. an IOException when trying to open a connection and send the next request
             if (hasIOExceptionFilters//
                     && t instanceof IOException//
                     && requestSender.applyIoExceptionFiltersAndReplayRequest(future, IOException.class.cast(t), channel)) {