Skip to content

Commit ec54882

Browse files
author
Stephane Landelle
committed
Prevent overwriting the host header with the host from the URI, close AsyncHttpClient#716
1 parent 375a288 commit ec54882

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

providers/netty/src/main/java/org/asynchttpclient/providers/netty/request/NettyRequestFactory.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,8 @@ public NettyRequest newNettyRequest(Request request, Uri uri, boolean forceConne
298298
headers.set(HttpHeaders.Names.CONNECTION, keepAliveHeaderValue(config));
299299
}
300300

301-
String hostHeader = hostHeader(request, uri);
302-
if (hostHeader != null && !headers.contains(HttpHeaders.Names.HOST))
303-
headers.set(HttpHeaders.Names.HOST, hostHeader);
301+
if (!headers.contains(HttpHeaders.Names.HOST))
302+
headers.set(HttpHeaders.Names.HOST, hostHeader(request, uri));
304303

305304
Realm realm = request.getRealm() != null ? request.getRealm() : config.getRealm();
306305
String authorizationHeader = authorizationHeader(request, uri, proxyServer, realm);

0 commit comments

Comments
 (0)