Skip to content

Commit 91585e2

Browse files
committed
Debounce all tracking events
1 parent a132416 commit 91585e2

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/editor/index.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import {
4141
} from "../dom-elements.js";
4242

4343
import log from "loglevel";
44-
import _ from "lodash";
4544

4645
// The event manager lets us enable/disable events as needed without
4746
// manually tracking them. Events that need to be disabled should be
@@ -439,18 +438,18 @@ function setupEvents() {
439438
eventManager.addCodeMirrorEvent(
440439
tokenEditor,
441440
"change",
442-
_.throttle(decodeToken, 1000)
441+
decodeToken
443442
);
444443
// When parts of the decoded token are changed, it must be reencoded.
445444
eventManager.addCodeMirrorEvent(
446445
headerEditor,
447446
"change",
448-
_.throttle(encodeToken, 1000)
447+
encodeToken
449448
);
450449
eventManager.addCodeMirrorEvent(
451450
payloadEditor,
452451
"change",
453-
_.throttle(encodeToken, 1000)
452+
encodeToken
454453
);
455454

456455
// HMAC secret, show tooltip if secret is too short.

src/metrics.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import log from "loglevel";
2+
import _ from "lodash";
3+
24

35
export function init() {
46
// Create a queue, but don't obliterate an existing one!
@@ -119,12 +121,12 @@ export function init() {
119121
analytics.page();
120122
}
121123

122-
export function track(event, data) {
124+
export const track = _.debounce((event, data) => {
123125
if (window.metrics) {
124126
try {
125127
window.metrics.track(event, data);
126128
} catch (e) {
127129
log.error(`Metrics library error for event ${event}: ${e}`);
128130
}
129131
}
130-
}
132+
}, 2000);

0 commit comments

Comments
 (0)