Merge pull request android-async-http#595 from fineswap/strictness-javadoc

Fix Javadoc, Add @OverRide, Stricter exception handling.

Author: smarek

library/src/main/java/com/loopj/android/http/AsyncHttpClient.java

@@ -1170,6 +1170,7 @@ public static String getUrlWithQueryString(boolean shouldEncodeUrl, String url,
      *
      * @param inputStream InputStream to be checked
      * @return true or false if the stream contains GZIP compressed data
+     * @throws java.io.IOException
      */
     public static boolean isInputStreamGZIPCompressed(final PushbackInputStream inputStream) throws IOException {
         if (inputStream == null)
@@ -1226,11 +1227,11 @@ private HttpEntity paramsToEntity(RequestParams params, ResponseHandlerInterface
             if (params != null) {
                 entity = params.getEntity(responseHandler);
             }
-        } catch (Throwable t) {
+        } catch (IOException e) {
             if (responseHandler != null)
-                responseHandler.sendFailureMessage(0, null, null, t);
+                responseHandler.sendFailureMessage(0, null, null, e);
             else
-                t.printStackTrace();
+                e.printStackTrace();
         }
 
         return entity;

library/src/main/java/com/loopj/android/http/FileAsyncHttpResponseHandler.java

@@ -74,8 +74,8 @@ protected File getTemporaryFile(Context context) {
         assert (context != null);
         try {
             return File.createTempFile("temp_", "_handled", context.getCacheDir());
-        } catch (Throwable t) {
-            Log.e(LOG_TAG, "Cannot create temporary file", t);
+        } catch (IOException e) {
+            Log.e(LOG_TAG, "Cannot create temporary file", e);
         }
         return null;
     }

library/src/main/java/com/loopj/android/http/MyRedirectHandler.java

@@ -52,6 +52,7 @@ public MyRedirectHandler(final boolean allowRedirects) {
         this.enableRedirects = allowRedirects;
     }
 
+    @Override
     public boolean isRedirectRequested(
             final HttpResponse response,
             final HttpContext context) {
@@ -73,6 +74,7 @@ public boolean isRedirectRequested(
         } //end of switch
     }
 
+    @Override
     public URI getLocationURI(
             final HttpResponse response,
             final HttpContext context) throws ProtocolException {

library/src/main/java/com/loopj/android/http/PersistentCookieStore.java

@@ -30,6 +30,9 @@
 import java.io.ByteArrayOutputStream;
 import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
+
+import java.io.IOException;
+
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
@@ -185,7 +188,8 @@ protected String encodeCookie(SerializableCookie cookie) {
         try {
             ObjectOutputStream outputStream = new ObjectOutputStream(os);
             outputStream.writeObject(cookie);
-        } catch (Exception e) {
+        } catch (IOException e) {
+            Log.d(LOG_TAG, "IOException in encodeCookie", e);
             return null;
         }
 
@@ -205,8 +209,10 @@ protected Cookie decodeCookie(String cookieString) {
         try {
             ObjectInputStream objectInputStream = new ObjectInputStream(byteArrayInputStream);
             cookie = ((SerializableCookie) objectInputStream.readObject()).getCookie();
-        } catch (Exception exception) {
-            Log.d(LOG_TAG, "decodeCookie failed", exception);
+        } catch (IOException e) {
+            Log.d(LOG_TAG, "IOException in decodeCookie", e);
+        } catch (ClassNotFoundException e) {
+            Log.d(LOG_TAG, "ClassNotFoundException in decodeCookie", e);
         }
 
         return cookie;

library/src/main/java/com/loopj/android/http/SaxAsyncHttpResponseHandler.java

@@ -54,6 +54,7 @@
  *     });
  * <pre/>
  *
+ * @param <T> Handler extending {@link org.xml.sax.helpers.DefaultHandler}
  * @see org.xml.sax.helpers.DefaultHandler
  * @see com.loopj.android.http.AsyncHttpResponseHandler
  */
@@ -83,6 +84,8 @@ public SaxAsyncHttpResponseHandler(T t) {
      * Deconstructs response into given content handler
      *
      * @param entity returned HttpEntity
+     * @return deconstructed response
+     * @throws java.io.IOException
      * @see org.apache.http.HttpEntity
      */
     @Override